test: add remote data source parsing tests #172
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| @Before | ||
| public void setUp() throws Exception { | ||
| if (Looper.getMainLooper() == null) { | ||
| try { | ||
| Method prepareMainLooper = Looper.class.getDeclaredMethod("prepareMainLooper"); | ||
| prepareMainLooper.setAccessible(true); | ||
| prepareMainLooper.invoke(null); | ||
| } catch (Exception ignored) { | ||
| Looper.prepare(); | ||
| } | ||
| } | ||
| RequestQueue queue = mock(RequestQueue.class); | ||
| dataSource = new DefaultHomeRemoteDataSource(queue, "https://example.com"); |
There was a problem hiding this comment.
[P1] Move remote data source tests off JVM
The new unit tests build a DefaultHomeRemoteDataSource in a local JVM test. Instantiating that class calls new Handler(Looper.getMainLooper()), but the JVM test environment ships only the stubbed android.os.Looper from android.jar. When ./gradlew test runs with a valid SDK, the call to Looper.getMainLooper() will throw RuntimeException: Method getMainLooper in android.os.Looper not mocked, so the entire test task fails before assertions execute. These tests need to run under Robolectric or the instrumentation androidTest source set, or the DefaultHomeRemoteDataSource should be refactored to avoid framework classes in local tests.
Useful? React with 👍 / 👎.
Summary
Testing
./gradlew test(fails: SDK location not found)https://chatgpt.com/codex/tasks/task_e_68c66132851c832d8e8c59ab5eb04e67