Add coverage for AppUsageNotificationWorker notification logic #226
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| @Test | ||
| public void doWork_postsNotificationWhenBeyondThreshold() { | ||
| long threshold = TimeUnit.DAYS.toMillis(3); | ||
| long lastUsed = System.currentTimeMillis() - threshold - TimeUnit.HOURS.toMillis(1); | ||
| when(sharedPreferences.getLong(eq("lastUsed"), anyLong())).thenReturn(lastUsed); | ||
|
|
||
| AppUsageNotificationWorker worker = createWorker(); | ||
|
|
||
| worker.doWork(); | ||
|
|
||
| verify(sharedPreferences).getLong("lastUsed", 0); | ||
| verify(notificationManager).createNotificationChannel(any(NotificationChannel.class)); | ||
| verify(notificationManager).notify(eq(0), any(Notification.class)); |
There was a problem hiding this comment.
[P1] Avoid invoking Android framework stubs in local unit tests
The new AppUsageNotificationWorkerTest lives under app/src/test, but the test methods construct the worker and exercise NotificationManager.createNotificationChannel and other framework APIs. Local JVM tests in this module run with the stubbed android.jar, so any call into NotificationManager or NotificationChannel will throw RuntimeException("Method … not mocked") unless the test runs under Robolectric or instrumentation. As-is, ./gradlew test will consistently fail once the Android SDK path issue is fixed. Consider converting this test to Robolectric or moving it under androidTest so that Android APIs are available.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68c976488a5c832d9864d1c2d4474b05