improve indetation and fix minor typo #286
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NASAWorldWind#262) * Fixes for DPI scaling. Mouse and select events now deliver GL surface coordinate values instead of the AWT screen coordinates. Added Windows JOGL jar files that include sgothel/jogl#110 and sgothel/jogl#112. Noticed that some null pointer exceptions occurred during KMLViewer startup; added null pointer checks. * Update for gluegen 9301bf1854 May 15 07:08:20 2023, jogl 900c35c6a4 May 15 06:47:22 2023 * Use DPI scaling to scale fonts rendered in the GLCanvas. * Update with gluegen/jogl code from 6/17/2023, gluegen commit 42bd110d9e, jogl commit 900c35c6a. Includes fix for jogl version of TextRenderer. Added Linux native jar files.
…n that is maintained by JOGAMP. Update JOGL jar files with released version 2.5.0, build Build: 2.5-b1533-20230818. That build includes the DPI scaling fix for TextRenderer, which was committed to the jogl repo on 6/4. (NASAWorldWind#272)
…ind#274) * Fix display of context menu in ContextMenusOnShapes demo. Retain copy of AWT screen coordinate when creating SelectEvent. * Fixes for drag and drop when DPI scaling in use, reported by NASAWorldWind#274 (comment) * Correct clamping of mouse position to viewport coordinates; previous edition has used AWT size of canvas, and mouse positions from MouseEvents are converted to GL surface coordinates early on. * Make pitch change of globe using right mouse work as it did before DPI scaling changes. Moving the mouse down should increase the pitch, so it appears that the top of the globe is rotated away from the eye. * Correction to commit 515167a; need to adjust mouse position Y for use by FlyViewInputHandler, and per frame mouse/key events. * Correct clamping of mouse position to viewport coordinates; previous edition has used AWT size of canvas, and mouse positions from MouseEvents are converted to GL surface coordinates early on. This commit fixes both X,Y limits, whereas commit d4b6bf4 only fixed Y.
…SAWorldWind#280) * Add support for retrieving EGM2008 offsets * Terminology and variable tweaks. * Merge develop * Revert formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Filling out this template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the
maintainer's discretion.
###Improved indentation and spacing.
###Fixed minor typos in comments (“inerpolantto” → “interpolant to”)
###Clarified parameter descriptions in constructors.
###Added local variable currentValue in nextDouble() for readability.