-
Notifications
You must be signed in to change notification settings - Fork 72
Add alias for rels and relations #2168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@fingolfin @fieker any objections? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2168 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 127 127
Lines 31776 31776
=======================================
Hits 27941 27941
Misses 3835 3835 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is unfortunately incompatible with the current Oscar master as this PR here turns https://github.com/oscar-system/Oscar.jl/blob/73e4186aa042c4f719dc06752f82bdd2da1bc572/src/Modules/UngradedModules/SubquoModule.jl#L2175 into a self-call (resulting in a StackOverflow when called). Since I still want to get this in eventually, I mark this as technically breaking, so we remember to add it to the next breaking AA release. |
|
I am fine with this but as you say, there is a problem with doing that in OSCAR. So first we need to change OSCAR to delegate the other way there (resp. turn So someone should open an issue for OSCAR, or provide a PR, to do that. |
|
Coming back to this now, I am not so sure I want |
|
Also note that Hecke defines (That's not an argument for anything, just one more thing to take into account when addressing this) |
Functions with both names existed with some taking the same arguments and computing the same thing.