-
Notifications
You must be signed in to change notification settings - Fork 68
[all hosts] (Office 2016) Account for Office 2016 and 2019 reaching end of support #2422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit e1fbda2: ✅ Validation status: passed
For more details, please refer to the build report. |
Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit eec25f0: ✅ Validation status: passed
For more details, please refer to the build report. |
Rick-Kirkham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not finished, but I need resolution on two questions before I continue reviewing.
| | Requirement set | Office on the web | Office on Windows<ul><li>Microsoft 365 subscription</li><li>retail perpetual</li></ul> | Office on Windows<ul><li>volume-licensed perpetual/[LTSC](/office/dev/add-ins/resources/resources-glossary#long-term-service-channel-ltsc)</li></ul> | Office on Mac | Office on iPad | Office Online Server | | ||
| |:-----|:-----|:-----|:-----|:-----|:-----|:-----| | ||
| | DialogOrigin 1.1 | Supported | Supported | Office 2016 | Version 16.52 (21080801) | Version 2.52 | Version 2108 (Build 10377.1000) | | ||
| | DialogOrigin 1.1 | Supported | Supported | Office 2021 | Version 16.52 (21080801) | Version 2.52 | Version 2108 (Build 10377.1000) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the reason for this change. We don't need to pretend that versions before Office 2021 don't exist. If Office 2016 supported this requirement set, then it still does. This change implies that it's not supported on versions before Office 2021.
I have more or less the same question about other changes in this PR, so I'll wait till this is resolved and then re-review.
| - Excel on Windows | ||
| - Microsoft 365 subscription | ||
| - perpetual Office 2016 and later | ||
| - perpetual Office 2021 and later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, here, why make this change and imply something false? Just because we don't support Office 2016 doesn't mean that it doesn't support ImageCoercion 1.1.
Office 2016 and Office 2019 have reached the end of support: https://support.microsoft.com/en-us/office/end-of-support-for-office-2016-and-office-2019-818c68bc-d5e5-47e5-b52f-ddf636cf8e16.
This PR addresses that by altering our documentation to list the minimum version of Office needed as 2021.