Skip to content

Conversation

@AlexJerabek
Copy link
Contributor

Office 2016 and Office 2019 have reached the end of support: https://support.microsoft.com/en-us/office/end-of-support-for-office-2016-and-office-2019-818c68bc-d5e5-47e5-b52f-ddf636cf8e16.

This PR addresses that by altering our documentation to list the minimum version of Office needed as 2021.

@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit e1fbda2:

✅ Validation status: passed

File Status Preview URL Details
docs/requirement-sets/common/dialog-api-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/common/dialog-origin-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/common/image-coercion-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/excel/excel-api-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/outlook/outlook-api-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/word/word-api-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)

For more details, please refer to the build report.

Co-authored-by: Elizabeth Samuel <elizs@microsoft.com>
@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit eec25f0:

✅ Validation status: passed

File Status Preview URL Details
docs/requirement-sets/common/dialog-api-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/common/dialog-origin-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/common/image-coercion-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/excel/excel-api-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/outlook/outlook-api-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)
docs/requirement-sets/word/word-api-requirement-sets.md ✅Succeeded View (>=common-js || >=outlook-js-1.1 || >=excel-js-1.1 || onenote-js-1.1 || >=powerpoint-js-1.1 || visio-js-1.1 || >=word-js-1.1)

For more details, please refer to the build report.

Copy link
Contributor

@Rick-Kirkham Rick-Kirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not finished, but I need resolution on two questions before I continue reviewing.

| Requirement set | Office on the web | Office on Windows<ul><li>Microsoft 365 subscription</li><li>retail perpetual</li></ul> | Office on Windows<ul><li>volume-licensed perpetual/[LTSC](/office/dev/add-ins/resources/resources-glossary#long-term-service-channel-ltsc)</li></ul> | Office on Mac | Office on iPad | Office Online Server |
|:-----|:-----|:-----|:-----|:-----|:-----|:-----|
| DialogOrigin 1.1 | Supported | Supported | Office 2016 | Version 16.52 (21080801) | Version 2.52 | Version 2108 (Build 10377.1000) |
| DialogOrigin 1.1 | Supported | Supported | Office 2021 | Version 16.52 (21080801) | Version 2.52 | Version 2108 (Build 10377.1000) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the reason for this change. We don't need to pretend that versions before Office 2021 don't exist. If Office 2016 supported this requirement set, then it still does. This change implies that it's not supported on versions before Office 2021.

I have more or less the same question about other changes in this PR, so I'll wait till this is resolved and then re-review.

- Excel on Windows
- Microsoft 365 subscription
- perpetual Office 2016 and later
- perpetual Office 2021 and later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, here, why make this change and imply something false? Just because we don't support Office 2016 doesn't mean that it doesn't support ImageCoercion 1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants