Skip to content

Conversation

@paagkame
Copy link
Contributor

@paagkame paagkame commented Dec 15, 2020

Reference to a related issue in the repository

#447

Add a description

Changed the start of vector pointing to the physical mounting position of the sensor.
It was: Center of the bounding box.
It is: Middle of the rear axis (coordinate system).

It is a bug fix according to the related issue.
It shall enhance the understanding of MovingObjects and the related coordinate systems.
It has not been tested. But since this is only an svg not code-related, no testing is needed.
Hence, I don't think it will break any existing functionality or force me to update to a new version.

Mention a member

@HendrikAmelunxen please reviewing proposed changes.

Check the checklist

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

Signed-off-by: Katrin Mehl <katrin.mehl@parson-europe.com>
@paagkame paagkame self-assigned this Dec 15, 2020
@paagkame paagkame added the Documentation Everything which impacts the quality of the documentation and guidelines. label Dec 15, 2020
@paagkame paagkame linked an issue Dec 15, 2020 that may be closed by this pull request
@paagkame
Copy link
Contributor Author

@HendrikAmelunxen

Here is what the svg looks now:
OSI_MovingObject
If Ok, please approve and label with ready for merge. If not, please label CCBReviewNeeded.

@paagkame
Copy link
Contributor Author

paagkame commented Dec 16, 2020

@pmai @HendrikAmelunxen

update of svg after input from ccb. Please have a look if this fits now:
OSI_MovingObject

A description about bbcenter_to_rear is documented here Which I used for naming the end of the vector from center of the bounding box to the rear axle.

Signed-off-by: Katrin Mehl <katrin.mehl@parson-europe.com>
Signed-off-by: Katrin Mehl <katrin.mehl@parson-europe.com>
@paagkame paagkame requested a review from pmai December 16, 2020 15:27
@stefancyliax stefancyliax added this to the V3.4.0 milestone Oct 29, 2021
Copy link
Contributor

@stefancyliax stefancyliax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image was approved in the SensorModelling WG meeting 29.10.2021

@stefancyliax stefancyliax merged commit d320712 into master Oct 29, 2021
@stefancyliax stefancyliax deleted the 447-wrong-vector-used-in-picture-in-movingobject branch October 29, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Everything which impacts the quality of the documentation and guidelines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong vector used in picture in MovingObject

4 participants