-
Notifications
You must be signed in to change notification settings - Fork 130
Harmonization of road mark colors with OpenDRIVE #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonization of road mark colors with OpenDRIVE #505
Conversation
HendrikAmelunxen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
|
Harmonisation 22.04.: \attention Deprecated: info "info" should contain the following: Provide information about the deprecated message.What needs to be changed/code adaption etc..e.g. Use assigned_lane_id in MovingObjectClassification instead.Provide information on when it will be deprecated.Specify the release version (usually, a major release ) |
|
Harmonisation 22.04.: |
|
At the moment, color is defined in four different files (osi_lane, osi_object, osi_featuredata and osi_roadmarking) as shown here: osi_lane.proto:
osi_object.proto:
osi_featuredata.proto:
osi_roadmarking.proto:
--> For OSI 4.0: centralize color in osi_common |
|
This topic is addressed in issue 512 #512 |
osi_lane.proto
Outdated
| // | ||
| COLOR_VIOLET = 8; | ||
|
|
||
| // Marking with orange color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably White space issue.
|
Output CCB 12.05.2021:
|
…Harmonization of road mark colors with OpenDRIVE Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
02b92c0 to
829c9fc
Compare
As suggested in #504:
1. Color orange is added to road mark colors
2. Color violet is marked as deprecated
Some questions to ask:
What is this change? --> only extension
What does it fix? --> harmonisation with OpenDrive
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested? --> only extension
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!