Skip to content

Add new DataQualifiers to DetectedEntityHeader #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add new DataQualifiers to DetectedEntityHeader #659

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c76a2c9
Added new elements to DataQualifier (REDUCE_INVIEW_AND_PERFORMANCE, T…
FlorianMueller87 Aug 9, 2022
7490af0
Merge branch 'master' into feature/add_elements_to_DataQualifier
jdsika Oct 17, 2022
3949e31
Corrected wrong enumeration name in DataQualifier
Nov 4, 2022
627ae74
Merge branch 'master' into feature/add_elements_to_DataQualifier
jdsika Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions osi_sensordata.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,22 @@ message DetectedEntityHeader
// Sensor temporary available.
//
DATA_QUALIFIER_TEMPORARY_AVAILABLE = 6;

// Reported data are from the sensor in a restricted view and performance.
//
DATA_QUALIFIER_REDUCE_INVIEW_AND_PERFORMANCE = 7;
Copy link
Contributor

@jdsika jdsika Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REDUCED_VIEW???

Copy link
Contributor

@jdsika jdsika Oct 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has COVERAGE from ISO been renamed to VIEW?

Copy link
Contributor Author

@FlorianMueller87 FlorianMueller87 Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISO and ADI both uses REDUCE

Yes, the name has changed, I will ask why.

Copy link
Contributor Author

@FlorianMueller87 FlorianMueller87 Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ViEW is also a mistake. I will change it to COVERAGE.


// Reported data are from the sensor in a test mode.
//
DATA_QUALIFIER_TEST_MODE= 8;

// Mesaurement cycle was invalid, and no valid objects will be reported.
//
DATA_QUALIFIER_INVALID = 9;

// Reported data are from the sensor in a restricted performance.
//
DATA_QUALIFIER_REDUCED_PERFORMANCE = 10;
}
}

Expand Down