Skip to content

Remove is_globally_unique rule from messages, where it does not make sense #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Remove is_globally_unique rule from messages, where it does not make sense #812

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
476c378
Remove is_globally_unique rule from messages, where it does not make …
ClemensLinnhoff May 10, 2024
fdfa143
Remove notes
ClemensLinnhoff May 10, 2024
0308040
Update osi_sensorview.proto
ClemensLinnhoff May 13, 2024
613456b
Update osi_referenceline.proto
ClemensLinnhoff May 13, 2024
de7b746
Add note to streaming update
ClemensLinnhoff May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions osi_lane.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,7 @@ message Lane
// The ID of the lane.
// Example: l4 (see reference picture HighwayExit).
//
// \note Note ID is global unique.
//
// \rules
// is_globally_unique
// is_set
// \endrules
//
Expand Down Expand Up @@ -713,7 +710,6 @@ message LaneBoundary
// The ID of the lane boundary.
//
// \rules
// is_globally_unique
// \endrules
//
optional Identifier id = 1;
Expand Down
7 changes: 0 additions & 7 deletions osi_logicallane.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ message LogicalLaneBoundary
// The ID of the lane boundary.
//
// \rules
// is_globally_unique
// is_set
// \endrules
//
Expand Down Expand Up @@ -330,12 +329,6 @@ message LogicalLane
{
// The ID of the logical lane.
//
// \note Note ID is global unique.
//
// \rules
// is_globally_unique
// \endrules
//
optional Identifier id = 1;

// The type of the logical lane.
Expand Down
7 changes: 0 additions & 7 deletions osi_referenceline.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@ message ReferenceLine
{
// The ID of the reference line.
//
// \note Note ID is global unique.
//
// \rules
// is_globally_unique
// is_set
// \endrules
//
optional Identifier id = 1;

// The type of the reference line.
Expand Down
5 changes: 0 additions & 5 deletions osi_sensorview.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,6 @@ message SensorView
// object output; it is distinct from the IDs of its physical detectors,
// which are used in the detected features.
//
// \rules
// is_globally_unique
// is_set
// \endrules
//
optional Identifier sensor_id = 3;

// The virtual mounting position of the sensor (origin and orientation of
Expand Down
2 changes: 0 additions & 2 deletions osi_streamingupdate.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,5 @@ message StreamingUpdate
// Entities that will no longer be updated, because they are considered
// obsolete by the sender.
//
// \note IDs are globally unique.
//
repeated Identifier obsolete_id = 9;
}