-
Notifications
You must be signed in to change notification settings - Fork 12.3k
Add AccessManagerEnumerable #6053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ernestognw
wants to merge
9
commits into
OpenZeppelin:master
Choose a base branch
from
ernestognw:feat/access-manager-enumerable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4374b53
Add AccessManagerEnumerable
ernestognw 841e6bb
Add interface, docs and tests
ernestognw b4af192
Add changeset
ernestognw b9e7965
up
ernestognw 2a0e900
Update list of functions by targets
ernestognw ab194a7
Add docs
ernestognw ba5a754
Merge branch 'master' into feat/access-manager-enumerable
ernestognw dad105c
Update doc references
ernestognw ece797a
up
ernestognw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
contracts/access/manager/extensions/AccessManagerEnumerable.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| pragma solidity ^0.8.20; | ||
|
|
||
| import {AccessManager} from "../AccessManager.sol"; | ||
| import {EnumerableSet} from "../../../utils/structs/EnumerableSet.sol"; | ||
|
|
||
| abstract contract AccessManagerEnumerable is AccessManager { | ||
| using EnumerableSet for EnumerableSet.AddressSet; | ||
| mapping(uint64 roleId => EnumerableSet.AddressSet) private _roleMembers; | ||
|
|
||
| function _grantRole( | ||
| uint64 roleId, | ||
| address account, | ||
| uint32 grantDelay, | ||
| uint32 executionDelay | ||
| ) internal override returns (bool) { | ||
| bool granted = super._grantRole(roleId, account, grantDelay, executionDelay); | ||
| if (granted) { | ||
| _roleMembers[roleId].add(account); | ||
| } | ||
| return granted; | ||
| } | ||
|
|
||
| function _revokeRole(uint64 roleId, address account) internal override returns (bool) { | ||
| bool revoked = super._revokeRole(roleId, account); | ||
| if (revoked) { | ||
| _roleMembers[roleId].remove(account); | ||
| } | ||
| return revoked; | ||
| } | ||
|
|
||
| function getRoleMembers(uint64 roleId, uint256 start, uint256 end) public view returns (address[] memory) { | ||
| return _roleMembers[roleId].values(start, end); | ||
| } | ||
ernestognw marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| function getRoleMemberCount(uint64 roleId) public view returns (uint256) { | ||
| return _roleMembers[roleId].length(); | ||
| } | ||
ernestognw marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.