Skip to content

WIP 3d #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP 3d #1100

wants to merge 1 commit into from

Conversation

@PhilipDeegan
Copy link
Member

@PhilipDeegan PhilipDeegan commented Nov 5, 2025

not ready, just here for TC tests

@PhilipDeegan PhilipDeegan marked this pull request as draft November 5, 2025 12:13
@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)
  • WIP

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 5, 2025
View reviewed changes
tests/diagnostic/test-diagnostics_3d.cpp
electromag_test(TypeParam{job_file}, out_dir);
}

TYPED_TEST(Simulator3dTest, allFromPython)

Check notice

Code scanning / CodeQL

Unused static variable

Static variable gtest_Simulator3dTest_allFromPython_registered_ is never read.
tests/diagnostic/test-diagnostics_3d.cpp
particles_test(TypeParam{job_file}, out_dir);
}

TYPED_TEST(Simulator3dTest, electromag)

Check notice

Code scanning / CodeQL

Unused static variable

Static variable gtest_Simulator3dTest_electromag_registered_ is never read.
tests/diagnostic/test-diagnostics_3d.cpp
fluid_test(TypeParam{job_file}, out_dir);
}

TYPED_TEST(Simulator3dTest, particles)

Check notice

Code scanning / CodeQL

Unused static variable

Static variable gtest_Simulator3dTest_particles_registered_ is never read.
tests/diagnostic/test-diagnostics_3d.cpp
static std::string const job_file = "job_3d";
static std::string const out_dir = "phare_outputs/diags_3d/";

TYPED_TEST(Simulator3dTest, fluid)

Check notice

Code scanning / CodeQL

Unused static variable

Static variable gtest_Simulator3dTest_fluid_registered_ is never read.
tests/diagnostic/test-diagnostics_3d.cpp

#include "core/def/phare_mpi.hpp"

#include "test_diagnostics.ipp"

Check notice

Code scanning / CodeQL

Include header files only

The #include pre-processor directive should only be used to include header files.
src/amr/tagging/default_hybrid_tagger_strategy.hpp
{
auto const& [start_y, __]
= layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
auto const& [start_z, ___]

Check notice

Code scanning / CodeQL

Unused local variable

Variable (unnamed local variable) is not used.
src/amr/tagging/default_hybrid_tagger_strategy.hpp
}
if constexpr (dimension == 3)
{
auto const& [start_y, __]

Check notice

Code scanning / CodeQL

Unused local variable

Variable __ is not used.
src/amr/tagging/default_hybrid_tagger_strategy.hpp
}
if constexpr (dimension == 3)
{
auto const& [start_y, __]

Check notice

Code scanning / CodeQL

Unused local variable

Variable (unnamed local variable) is not used.
src/amr/messengers/hybrid_hybrid_messenger_strategy.hpp Outdated
auto& J = hybridModel.state.J;
auto& Vi = hybridModel.state.ions.velocity();
auto& Ni = hybridModel.state.ions.chargeDensity();
auto& E = hybridModel.state.electromag.E;

Check notice

Code scanning / CodeQL

Unused local variable

Variable E is not used.
src/amr/data/particles/refine/splitter.hpp
using FineParticle = decltype(particles[0]); // may be a reference

core::apply(patterns, [&](auto const& pattern) {
auto weight = static_cast<Weight_t>(pattern.weight_);

Check notice

Code scanning / CodeQL

Unused local variable

Variable weight is not used.
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 5, 2025
View reviewed changes
tests/diagnostic/test-diagnostics_3d.cpp
electromag_test(TypeParam{job_file}, out_dir);
}

TYPED_TEST(Simulator3dTest, allFromPython)

Check notice

Code scanning / CodeQL

Unused static variable Note test

Static variable gtest_Simulator3dTest_allFromPython_registered_ is never read.
tests/diagnostic/test-diagnostics_3d.cpp
particles_test(TypeParam{job_file}, out_dir);
}

TYPED_TEST(Simulator3dTest, electromag)

Check notice

Code scanning / CodeQL

Unused static variable Note test

Static variable gtest_Simulator3dTest_electromag_registered_ is never read.
tests/diagnostic/test-diagnostics_3d.cpp
fluid_test(TypeParam{job_file}, out_dir);
}

TYPED_TEST(Simulator3dTest, particles)

Check notice

Code scanning / CodeQL

Unused static variable Note test

Static variable gtest_Simulator3dTest_particles_registered_ is never read.
tests/diagnostic/test-diagnostics_3d.cpp
static std::string const job_file = "job_3d";
static std::string const out_dir = "phare_outputs/diags_3d/";

TYPED_TEST(Simulator3dTest, fluid)

Check notice

Code scanning / CodeQL

Unused static variable Note test

Static variable gtest_Simulator3dTest_fluid_registered_ is never read.
tests/diagnostic/test-diagnostics_3d.cpp

#include "core/def/phare_mpi.hpp"

#include "test_diagnostics.ipp"

Check notice

Code scanning / CodeQL

Include header files only Note test

The #include pre-processor directive should only be used to include header files.
src/amr/tagging/default_hybrid_tagger_strategy.hpp
return std::make_tuple(criter_x, criter_y, criter_z);
};

auto const& [Bx_x, Bx_y, Bx_z] = field_diff(Bx);

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable (unnamed local variable) is not used.
src/amr/tagging/default_hybrid_tagger_strategy.hpp
{
auto const& [start_y, __]
= layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
auto const& [start_z, ___]

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable ___ is not used.
src/amr/tagging/default_hybrid_tagger_strategy.hpp
{
auto const& [start_y, __]
= layout.physicalStartToEnd(PHARE::core::QtyCentering::dual, PHARE::core::Direction::Y);
auto const& [start_z, ___]

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable (unnamed local variable) is not used.
src/amr/tagging/default_hybrid_tagger_strategy.hpp
}
if constexpr (dimension == 3)
{
auto const& [start_y, __]

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable __ is not used.
src/amr/tagging/default_hybrid_tagger_strategy.hpp
}
if constexpr (dimension == 3)
{
auto const& [start_y, __]

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable (unnamed local variable) is not used.
@PhilipDeegan PhilipDeegan force-pushed the 3d_new branch 2 times, most recently from e1b7238 to 4de43d2 Compare November 7, 2025 15:11
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 7, 2025
View reviewed changes
src/core/numerics/pusher/fusher.hpp
Comment on lines +9 to +10
// #include "core/utilities/range/range.hpp"
// #include "core/data/particles/particle.hpp"

Check notice

Code scanning / CodeQL

Commented-out code

This comment appears to contain commented-out code.
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 7, 2025
View reviewed changes
src/core/numerics/pusher/fusher.hpp
Comment on lines +9 to +10
// #include "core/utilities/range/range.hpp"
// #include "core/data/particles/particle.hpp"

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@PhilipDeegan PhilipDeegan mentioned this pull request Nov 8, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PhilipDeegan