Skip to content

Add support for Symfony 8 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2025
Merged

Add support for Symfony 8 #13

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7562575
Add support for Symfony 8
Kocal Nov 4, 2025
71e0de4
[CI] Remove new steps for Symfony Flex & SYMFONY_REQUIRE
Kocal Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ jobs:
- php: "8.2"
- php: "8.3"
- php: "8.4"
- php: "8.4"
symfony-version: 8.0.x-dev
Copy link

@stof stof Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think adding a job testing specifically Symfony 8.0.x-dev makes sense. A job using dev versions of dependency will already install the latest compatible dev version, which will be 8.0.x-dev now, but would automatically update to newer versions in the future without requiring additional maintenance work in the CI setup.

Copy link
Contributor Author

@Kocal Kocal Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may be right, I removed it in a new commit.
Thanks!

composer-stability: dev
Copy link
Member

@keradus keradus Nov 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it still installs symfony/process v7
https://github.com/PHP-CS-Fixer/cli-executor/actions/runs/19081571203/job/54521925562#step:5:86

Copy link
Contributor Author

@Kocal Kocal Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because of PHP-CS-Fixer itself:

➜  php-cs-fixer-cli-executor git:(symfony-8) ✗ sfcp why-not symfony/process ^8.0
friendsofphp/php-cs-fixer v3.89.1 requires symfony/process (^5.4.47 || ^6.4.24 || ^7.2)

Couldn't we use the PHP-CS-Fixer shim?

Copy link
Member

@keradus keradus Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can

simply without showing v8 on CI, we gamble if this change works

steps:
- name: Checkout source
uses: actions/checkout@v4
Expand All @@ -27,8 +30,18 @@ jobs:
with:
php-version: ${{ matrix.php }}
ini-values: zend.assertions=1, error_reporting=-1, display_errors=On, log_errors_max_len=0
- name: Install and configure Symfony Flex
if: matrix.symfony-version
run: |
composer global require --no-progress --no-scripts --no-plugins symfony/flex
composer global config --no-plugins allow-plugins.symfony/flex true
- name: Configure Composer minimum-stability
if: matrix.composer-stability
run: composer config minimum-stability ${{ matrix.composer-stability }}
- name: "Update composer dependencies"
run: composer update -o --no-interaction --no-progress ${{ matrix.COMPOSER_FLAGS }}
env:
SYMFONY_REQUIRE: ${{ matrix.symfony-version }}
- name: Tests
env:
PHP_CS_FIXER_IGNORE_ENV: ${{ matrix.PHP_CS_FIXER_IGNORE_ENV }}
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
],
"require": {
"php": "^7.4 || ^8.0",
"symfony/process": "^5.4 || ^6.4 || ^7.2"
"symfony/process": "^5.4 || ^6.4 || ^7.2 || ^8.0"
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^3.75",
Expand Down