[Infra] Use pyproject.toml instead of setup.cfg
#294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wj-Mcat
reviewed
Jan 16, 2024
Comment on lines
-20
to
-24
| git_version: Optional[str] | ||
| try: | ||
| git_version = subprocess.check_output(["git", "rev-parse", "HEAD"]).decode("ascii").strip() | ||
| except (OSError, subprocess.CalledProcessError): | ||
| git_version = None |
Collaborator
There was a problem hiding this comment.
这个在打包的时候会把 git 信息打包进去吗？如果会的话，那 pyproject.toml 如何试下这个功能呢？
Member
Author
There was a problem hiding this comment.
这个目前应该是完全没有用，我们也没有用到setuptools-scm等能够记录git版本号的工具～
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
自PEP 621开始，
pyproject.toml已经成为现代Python配置项目元信息的标准方式。目前ERNIE SDK中各项目尚未完全跟进PEP 621，而是采用强依赖于setuptools的“历史遗留”方式：setup.py、setup.cfg与pyproject.toml共同存在，pyproject.toml仅用于配置formatter和linter。本PR将SDK中各项目的项目元信息配置方式进行“现代化”，统一为PEP 621鼓励的方式。