Skip to content

Change maximum version #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Change maximum version #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion PSWebServiceLibrary.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class PrestaShopWebservice
/** @var string Minimal version of PrestaShop to use with this library */
const psCompatibleVersionsMin = '1.4.0.0';
/** @var string Maximal version of PrestaShop to use with this library */
const psCompatibleVersionsMax = '8.2.0';
const psCompatibleVersionsMax = '9.0.0';
Copy link
Member

@boherm boherm Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we haven't tested this module on 9.0.0, maybe we should set 8.2.99 to the max for now 🤔
(In the future, I think that we can remove totally the max compatible version thing here 🤷‍♂️)

Suggested change
const psCompatibleVersionsMax = '9.0.0';
const psCompatibleVersionsMax = '8.2.99';

Copy link
Member

@boherm boherm Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tleon


/**
* PrestaShopWebservice constructor. Throw an exception when CURL is not installed/activated
Expand Down