Skip to content

Conversation

@chaunceyjiang
Copy link
Contributor

@chaunceyjiang chaunceyjiang commented Jan 8, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:

Pods with containers in privileged mode and declaring HAMi-related resources should be prevented from being created.

Which issue(s) this PR fixes:
Fixes #790

Test:

image

image

Does this PR introduce a user-facing change?:

@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 47.24% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/scheduler/webhook.go 65.45% <100.00%> (+9.45%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ources. Its creation is denied.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@lengrongfu
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pods in privileged mode keep encountering the UnexpectedAdmissionError error.

2 participants