refactor!: ConnectionState & Event Handling #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
definitely doesn't work yet, just felt like there was way too much changes not to commit already
Paillat-dev
reviewed
May 13, 2025
Paillat-dev
reviewed
May 13, 2025
Paillat-dev
reviewed
May 13, 2025
Paillat-dev
reviewed
May 13, 2025
large part left is the ConnectionState itself since events haven't been transformed yet
I need to make more commits
Paillat-dev
requested changes
May 16, 2025
Member
Paillat-dev
left a comment
Paillat-dev
left a comment
There was a problem hiding this comment.
I didn't try running the code yet, will do that later today
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: VincentRPS <vincentbusiness55@gmail.com>
Member
|
@VincentRPS You should also import defaultdict |
Member
|
Any news ? See traceback of another error here: https://canary.discord.com/channels/881207955029110855/881735314987708456/1373639761696133160 |
Signed-off-by: VincentRPS <vincentbusiness55@gmail.com>
Member
|
Congrats @VincentRPS you successfully broke the docs ! 🎉 |
Paillat-dev
requested changes
May 31, 2025
Co-authored-by: Paillat <jeremiecotti@ik.me> Signed-off-by: VincentRPS <vincentbusiness55@gmail.com>
Member
|
@VincentRPS I am going to rebase this for you and push here |
Author
M'kay! |
Paillat-dev
changed the title
…guild_role_update, guild_role_delete
plun1331
reviewed
Sep 9, 2025
| ) | ||
| return | ||
|
|
||
| member = await guild.get_member(int(data["user"]["id"])) |
Member
There was a problem hiding this comment.
Normally people aren't members of guilds that they're being unbanned from
EmmmaTech
reviewed
Oct 22, 2025
| return await self.cache.get_all_stickers() | ||
|
|
||
| async def get_emoji(self, emoji_id: int | None) -> GuildEmoji | AppEmoji | None: | ||
| return await self.get_emoji(emoji_id) |
There was a problem hiding this comment.
Suggested change
| return await self.get_emoji(emoji_id) | |
| return await self.cache.get_emoji(emoji_id) |
| await state.maybe_store_app_emoji(state.application_id, e) | ||
|
|
||
|
|
||
| class GuildCreate(Event, Guild): |
There was a problem hiding this comment.
this (among a few other events) appears to be duplicated in guild.py?
discord/app/state.py
Outdated
| else: | ||
| self.dispatch("guild_join", guild) | ||
|
|
||
| def parse_guild_audit_log_entry_create(self, data) -> None: |
There was a problem hiding this comment.
I assume these leftover parse functions have yet to be converted into events?
|
@VincentRPS are you still working on this ? |
Migrate 18 remaining parse_x methods from ConnectionState to new Event subclasses following the established event migration pattern.
Created event files:
- audit_log.py: GuildAuditLogEntryCreate
- scheduled_event.py: GuildScheduledEvent{Create,Update,Delete,UserAdd,UserRemove}
- integration.py: GuildIntegrationsUpdate, Integration{Create,Update,Delete}
- stage_instance.py: StageInstance{Create,Update,Delete}
- voice.py: VoiceStateUpdate, VoiceServerUpdate, VoiceChannelStatusUpdate
- typing.py: TypingStart
- webhook.py: WebhooksUpdate
Changes to ConnectionState:
- Removed 18 parse_x methods
- Removed _get_typing_user helper (moved to typing.py)
- Cleaned up unused imports (AuditLogEntry, ScheduledEventStatus, _integration_factory, ScheduledEvent, StageInstance)
- Kept parse_guild_members_chunk (internal infrastructure)
Bug fixes:
- Fixed subscriber count decrement in GuildScheduledEventUserRemove
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
definitely doesn't work yet