[CodeGen][InlineSpiller] Enable subreg spill-restore during RA #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The register tuple spilling during RA is suboptimal when we restore the entire tuple before the instructions that has only the subreg use of the original tuple. This will lead to unwanted register pressure and cases of unsuccessful allocation when deal with tests of large value types. This patch allows targets to enable subreg reloads by constructing a super class matching the subreg(s) involved in the MI in question and eventually would improve the allocation by avoiding the unwanted subreg reload components in the first place.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The register tuple spilling during RA is suboptimal when we restore the entire tuple before the instructions that has only the subreg use of the original tuple. This will lead to unwanted register pressure and cases of unsuccessful allocation when deal with tests of large value types.
This patch allows targets to enable subreg reloads by constructing a super class matching the subreg(s) involved in the MI in question and eventually would improve the allocation by avoiding the unwanted subreg reload components in the first place.