Skip to content

test(business): Add more validation tests for the detail endpoint. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

test(business): Add more validation tests for the detail endpoint. #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 57 additions & 24 deletions promo_code/business/tests/promocodes/validations/test_detail_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,17 +129,16 @@ def test_edit_invalid_short_description(self):
[
(
'non_string',
{'description': 'Bonus 10000%!', 'image_url': False},
{'image_url': False},
),
(
'incomplete_url',
{'description': 'Bonus 10000%!', 'image_url': 'https://'},
{'image_url': 'https://'},
),
(
'malformed_url',
{'description': 'Bonus 10000%!', 'image_url': 'notalink'},
{'image_url': 'notalink'},
),
('incorrect_type', {'image_url': 'jpeg'}),
],
)
def test_edit_invalid_image_urls(self, _, patch_payload):
Expand Down Expand Up @@ -188,29 +187,63 @@ def test_edit_invalid_target(self, _, patch_payload):
rest_framework.status.HTTP_400_BAD_REQUEST,
)

def test_edit_invalid_max_count_for_unique(self):
promo_id = self.create_promo(self.company2_token, self.unique_payload)
self.client.credentials(
HTTP_AUTHORIZATION='Bearer ' + self.company2_token,
)
url = self.promo_detail_url(promo_id)
patch_payload = {
'max_count': 10,
}
response = self.client.patch(url, patch_payload, format='json')
self.assertEqual(
response.status_code,
rest_framework.status.HTTP_400_BAD_REQUEST,
)
@parameterized.parameterized.expand(
[
(
'unique_max_count',
'company2_token',
'unique_payload',
{'max_count': 10},
),
(
'negative_max_count',
'company1_token',
'common_payload',
{'max_count': -10},
),
(
'non_integer_max_count',
'company1_token',
'common_payload',
{'max_count': 'invalid'},
),
(
'zero_max_count',
'company2_token',
'unique_payload',
{'max_count': 0},
),
(
'max_count_is_none',
'company1_token',
'common_payload',
{'max_count': None},
),
(
'exceeding_max_count',
'company1_token',
'common_payload',
{'max_count': 100_000_001},
),
],
)
def test_edit_invalid_max_count(
self,
_,
token_attr,
payload_attr,
patch_payload,
):
token = getattr(self, token_attr)
create_payload = getattr(self, payload_attr)

def test_edit_negative_max_count(self):
promo_id = self.create_promo(self.company1_token, self.common_payload)
self.client.credentials(
HTTP_AUTHORIZATION='Bearer ' + self.company1_token,
)
promo_id = self.create_promo(token, create_payload)

self.client.credentials(HTTP_AUTHORIZATION='Bearer ' + token)
url = self.promo_detail_url(promo_id)
patch_payload = {'max_count': -10}

response = self.client.patch(url, patch_payload, format='json')

self.assertEqual(
response.status_code,
rest_framework.status.HTTP_400_BAD_REQUEST,
Expand Down