feat: skip generation for invalid stubs #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenTray
requested changes
Dec 2, 2024
src/Generators/EntityGenerator.php
Outdated
| return view($stubPath)->with($data)->render(); | ||
| } | ||
|
|
||
| protected function checkStubExists(string $stub): bool |
Collaborator
There was a problem hiding this comment.
Suggested change
| protected function checkStubExists(string $stub): bool | |
| protected function isStubExists(string $stubName): bool |
src/Generators/SeederGenerator.php
Outdated
|
|
||
| public function generate(): void | ||
| { | ||
| $entitySeeder = (version_compare(app()->version(), '8', '>=')) ? 'seeder' : 'legacy_seeder'; |
Collaborator
There was a problem hiding this comment.
let's remove legacy seeder check
tests/SeederGeneratorTest.php
Outdated
Comment on lines
70
to
72
| config([ | ||
| 'entity-generator.stubs.seeder' => 'incorrect_stub', | ||
| ]); |
Collaborator
There was a problem hiding this comment.
Suggested change
| config([ | |
| 'entity-generator.stubs.seeder' => 'incorrect_stub', | |
| ]); | |
| config(['entity-generator.stubs.seeder' => 'incorrect_stub']); |
DenTray
approved these changes
Dec 6, 2024
DenTray
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #93