Skip to content

refactor: remove useless json extensions #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

refactor: remove useless json extensions #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
addf3a5
refactor: remove useless json extensions
RGO230 Jun 2, 2025
5ccff56
fix:tests
RGO230 Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions stubs/nova_test.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ public static function getRun{{$entity}}ActionsData(): array
'request' => [
'resources' => '1,2',
],
'state' => 'run_{{$action['fixture']}}_state.json',
'state' => 'run_{{$action['fixture']}}_state',
],
@endforeach
];
Expand All @@ -204,7 +204,7 @@ public static function get{{$entity}}ActionsData(): array
@foreach($actions as $action)
[
'resources' => [1, 2],
'fixture' => 'get_{{$snake_entity}}_actions_{{$action['fixture']}}.json',
'fixture' => 'get_{{$snake_entity}}_actions_{{$action['fixture']}}',
],
@endforeach
];
Expand All @@ -229,7 +229,7 @@ public static function get{{$entity}}FiltersData(): array
'request' => [
'{{$filter['name']}}' => $this->novaSearchParams(['search term']),
],
'fixture' => 'filter_{{$snake_entity}}_by_{{$filter['fixture_name']}}.json',
'fixture' => 'filter_{{$snake_entity}}_by_{{$filter['fixture_name']}}',
],
@endforeach
];
Expand Down
4 changes: 2 additions & 2 deletions stubs/test.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,14 @@ public static function getSearchFilters(): array
return [
[
'filter' => ['all' => 1],
'fixture' => 'search_all.json',
'fixture' => 'search_all',
],
[
'filter' => [
'page' => 2,
'per_page' => 2,
],
'fixture' => 'search_by_page_per_page.json',
'fixture' => 'search_by_page_per_page',
],
];
}
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/CommandTest/test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,14 @@ public static function getSearchFilters(): array
return [
[
'filter' => ['all' => 1],
'fixture' => 'search_all.json',
'fixture' => 'search_all',
],
[
'filter' => [
'page' => 2,
'per_page' => 2,
],
'fixture' => 'search_by_page_per_page.json',
'fixture' => 'search_by_page_per_page',
],
];
}
Expand Down
12 changes: 6 additions & 6 deletions tests/fixtures/NovaTestGeneratorTest/created_resource_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,14 @@ public static function getRunWelcomeBonusActionsData(): array
'request' => [
'resources' => '1,2',
],
'state' => 'run_publish_post_action_state.json',
'state' => 'run_publish_post_action_state',
],
[
'action' => UnPublishPostAction::class,
'request' => [
'resources' => '1,2',
],
'state' => 'run_un_publish_post_action_state.json',
'state' => 'run_un_publish_post_action_state',
],
];
}
Expand All @@ -210,11 +210,11 @@ public static function getWelcomeBonusActionsData(): array
return [
[
'resources' => [1, 2],
'fixture' => 'get_welcome_bonus_actions_publish_post_action.json',
'fixture' => 'get_welcome_bonus_actions_publish_post_action',
],
[
'resources' => [1, 2],
'fixture' => 'get_welcome_bonus_actions_un_publish_post_action.json',
'fixture' => 'get_welcome_bonus_actions_un_publish_post_action',
],
];
}
Expand All @@ -237,13 +237,13 @@ public static function getWelcomeBonusFiltersData(): array
'request' => [
'TextField:description_field' => $this->novaSearchParams(['search term']),
],
'fixture' => 'filter_welcome_bonus_by_text_field.json',
'fixture' => 'filter_welcome_bonus_by_text_field',
],
[
'request' => [
'RonasIT\Support\Tests\Support\NovaTestGeneratorTest\CreatedAtFilter' => $this->novaSearchParams(['search term']),
],
'fixture' => 'filter_welcome_bonus_by_created_at_filter.json',
'fixture' => 'filter_welcome_bonus_by_created_at_filter',
],
];
}
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/TestGeneratorTest/post_test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,14 +137,14 @@ public static function getSearchFilters(): array
return [
[
'filter' => ['all' => 1],
'fixture' => 'search_all.json',
'fixture' => 'search_all',
],
[
'filter' => [
'page' => 2,
'per_page' => 2,
],
'fixture' => 'search_by_page_per_page.json',
'fixture' => 'search_by_page_per_page',
],
];
}
Expand Down
4 changes: 2 additions & 2 deletions tests/fixtures/TestGeneratorTest/post_test_read_delete.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@ public static function getSearchFilters(): array
return [
[
'filter' => ['all' => 1],
'fixture' => 'search_all.json',
'fixture' => 'search_all',
],
[
'filter' => [
'page' => 2,
'per_page' => 2,
],
'fixture' => 'search_by_page_per_page.json',
'fixture' => 'search_by_page_per_page',
],
];
}
Expand Down