refactor: use resource in generate only nova tests #163

RGO230 · 2025-06-25T12:56:41Z

#159

…rator-instead-of-Model

src/Commands/MakeEntityCommand.php

src/Generators/NovaTestGenerator.php

tests/CommandTest.php

…rator-instead-of-Model

AZabolotnikov · 2025-07-29T06:50:48Z

src/Generators/NovaTestGenerator.php

            }

-            if ($this->classExists('nova', "Nova{$this->model}Test")) {
+            $this->isNovaResourceExists();


Suggested change

$this->isNovaResourceExists();

$resource = $this->resourceName ?? $this->getNovaResource();

$this->shortNovaResourceName = Str::afterLast($resource, '\\');

$this->fullNovaResourcePath = "App\\Nova\\{$resource}";

AZabolotnikov · 2025-07-29T06:55:08Z

src/Generators/NovaTestGenerator.php

+        }
+    }
+
+    protected function getNovaResource(): ?string


Suggested change

protected function getNovaResource(): ?string

protected function getNovaResource(): string

{

$commonResources = $this->getCommonNovaResources();

if (count($commonResources) > 1) {

$commonResources = implode(', ', $commonResources);

$this->throwFailureException(

EntityCreateException::class,

"Cannot create Nova{$this->model}Resource Test cause was found a lot of suitable resources: $commonResources",

"Please, use --resource-name option"

);

}

return array_pop($commonResources);

}

AZabolotnikov · 2025-07-29T06:57:10Z

src/Generators/NovaTestGenerator.php

+        return $resources;
+    }
+
+    protected function isValidCommonResourceCheck(string $resource)


please separate the checks to two methods isValidCommonResourceCheck - not need

$this->isNovaResource($class)

$this->isResourceNameContainModel($class)

AZabolotnikov · 2025-07-29T06:57:48Z

src/Generators/NovaTestGenerator.php

+        }
+    }
+
+    protected function getCommonNovaResources(): array


Suggested change

protected function getCommonNovaResources(): array

protected function getCommonNovaResources(): array

{

$resources = [];

foreach ($this->getNovaFiles() as $file) {

$relativePath = Str::after($file->getPathname(), $this->novaPath . DIRECTORY_SEPARATOR);

$class = str_replace(['/', '.php'], ['\\', ''], $relativePath);

if ($this->isNovaResource($class) && $this->isResourceNameContainModel($class)) {

$resources[] = $class;

}

}

return $resources;

}

AZabolotnikov · 2025-07-29T06:58:13Z

src/Generators/NovaTestGenerator.php

+        }
+    }
+
+    protected function allCommonNovaResources(): Generator


protected function getNovaFiles(): Generator { $iterator = new RecursiveIteratorIterator(new RecursiveDirectoryIterator($this->novaPath)); foreach ($iterator as $file) { if ($file->isFile() && $file->getExtension() === 'php') { yield $file; } } }

Copilot

Pull Request Overview

This PR refactors the Nova test generator to use the Laravel Nova Resource class import, addressing GitHub issue #159. The changes improve the structure and naming conventions for Nova test generation and add support for specifying custom resource names.

Key changes:

Added explicit use Laravel\Nova\Resource; imports to generated Nova resource files
Renamed Nova test files from NovaModelTest to NovaResourceNameTest format
Added --resource-name option for specifying custom Nova resource names when generating tests

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
stubs/nova_resource.blade.php	Added explicit Laravel\Nova\Resource import
src/Generators/NovaTestGenerator.php	Major refactor to support resource-based naming and custom resource names
src/Commands/MakeEntityCommand.php	Added --resource-name command option
tests/fixtures/	Multiple test fixture files updated to reflect new naming conventions
tests/Support/	Updated test support files and mocks for new resource handling
composer.json	Added Laravel\Nova namespace mapping for tests
ReadMe.md	Updated documentation with new command options

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-28T09:37:43Z

tests/fixtures/NovaTestGeneratorTest/created_post_resource_test.php

+{
+    use NovaTestTrait;
+
+    protected static User $user;


Missing import for User class. The User class is referenced but not imported at the top of the file.

Copilot · 2025-08-28T09:37:43Z

tests/fixtures/NovaTestGeneratorTest/created_post_resource_test.php

+        return [
+            [
+                'request' => [
+                    'TextField:description_field' => $this->novaSearchParams(['search term']),


The method novaSearchParams is called as an instance method with $this-> but this appears to be in a static context within a data provider method.

Copilot · 2025-08-28T09:37:44Z

tests/fixtures/NovaTestGeneratorTest/created_post_resource_test.php

+    {
+        return [
+            [
+                'action' => PublishPostAction::class,


Missing import for PublishPostAction class. The class is referenced but not imported at the top of the file.

AZabolotnikov · 2025-09-04T11:12:27Z

src/Generators/NovaTestGenerator.php

    protected function loadNovaFilters()
    {
-        return app("\\App\\Nova\\{$this->novaModelName}")->filters(new NovaRequest());
+        return app("{$this->fullNovaResourcePath}")->filters(new NovaRequest());


Suggested change

return app("{$this->fullNovaResourcePath}")->filters(new NovaRequest());

return app($this->fullNovaResourcePath)->filters(new NovaRequest());

AZabolotnikov · 2025-09-04T11:21:48Z

src/Generators/NovaTestGenerator.php

+
+    protected function isResourceNameContainModel(string $resource): bool
+    {
+        return Str::afterLast(str_replace('Resource', '', $resource), '\\') === $this->model;


contain or hard equal? Are you sure? If resourse will have name WelcomeBonusDraftResource.php

AZabolotnikov · 2025-09-04T11:25:54Z

src/Generators/NovaTestGenerator.php

    protected function loadNovaFields()
    {
-        return app("\\App\\Nova\\{$this->novaModelName}")->fields(new NovaRequest());
+        return app("{$this->fullNovaResourcePath}")->fields(new NovaRequest());


Suggested change

return app("{$this->fullNovaResourcePath}")->fields(new NovaRequest());

return app($this->fullNovaResourcePath)->fields(new NovaRequest());

AZabolotnikov · 2025-09-04T11:26:07Z

src/Generators/NovaTestGenerator.php

    protected function loadNovaActions()
    {
-        return app("\\App\\Nova\\{$this->novaModelName}")->actions(new NovaRequest());
+        return app("{$this->fullNovaResourcePath}")->actions(new NovaRequest());


Suggested change

return app("{$this->fullNovaResourcePath}")->actions(new NovaRequest());

return app($this->fullNovaResourcePath)->actions(new NovaRequest());

AZabolotnikov · 2025-09-05T04:54:29Z

@RGO230 please don't touch this pull request until this request is merged #165

RGO230 added 6 commits June 25, 2025 15:49

refactor: use resource in generate only nova tests

b431fb6

fix: tests

563f2c2

fix:tests

8a19c3a

fix:Tests

33ca7bc

fix:tests

516473b

Merge branch 'master' into 140-use-NovaResource-class-in-NovaTestGene…

bc9b17e

…rator-instead-of-Model

RGO230 assigned AZabolotnikov and RGO230 and unassigned AZabolotnikov Jun 27, 2025

RGO230 added 2 commits July 1, 2025 17:06

refactor: change set resource from argument ot option

b5d870d

style: fix

1f250a2

RGO230 assigned AZabolotnikov and RGO230 and unassigned RGO230 and AZabolotnikov Jul 1, 2025

refactor: remove useless

5c49cec

RGO230 assigned AZabolotnikov and unassigned RGO230 Jul 2, 2025

AZabolotnikov assigned RGO230 and unassigned AZabolotnikov Jul 3, 2025

AZabolotnikov reviewed Jul 3, 2025

View reviewed changes

src/Commands/MakeEntityCommand.php Outdated Show resolved Hide resolved

src/Generators/NovaTestGenerator.php Outdated Show resolved Hide resolved

src/Generators/NovaTestGenerator.php Outdated Show resolved Hide resolved

src/Generators/NovaTestGenerator.php Outdated Show resolved Hide resolved

AZabolotnikov reviewed Jul 3, 2025

View reviewed changes

src/Generators/NovaTestGenerator.php Outdated Show resolved Hide resolved

AZabolotnikov reviewed Jul 3, 2025

View reviewed changes

tests/CommandTest.php Show resolved Hide resolved

AZabolotnikov assigned AZabolotnikov and RGO230 and unassigned RGO230 and AZabolotnikov Jul 3, 2025

RGO230 added 3 commits July 8, 2025 13:16

Merge branch 'master' into 140-use-NovaResource-class-in-NovaTestGene…

9a92f95

…rator-instead-of-Model

fix:tests

a66d9ce

refactor: check only nova resources

c45d415

RGO230 assigned AZabolotnikov and RGO230 and unassigned RGO230 and AZabolotnikov Jul 9, 2025

chore:update readme

fd12be4

RGO230 assigned RGO230 and unassigned AZabolotnikov Jul 10, 2025

refactor:use common resources

a6a2747

RGO230 assigned AZabolotnikov and unassigned RGO230 Jul 11, 2025

style:fix

f3fa391

AZabolotnikov reviewed Jul 29, 2025

View reviewed changes

AZabolotnikov assigned RGO230 and unassigned AZabolotnikov Jul 29, 2025

astorozhevsky requested a review from Copilot August 28, 2025 09:36

Copilot AI reviewed Aug 28, 2025

View reviewed changes

refactor: remove useless from generator

d0cc813

RGO230 assigned AZabolotnikov and unassigned RGO230 Sep 2, 2025

AZabolotnikov reviewed Sep 4, 2025

View reviewed changes

RonasIT deleted a comment from Copilot AI Sep 4, 2025

AZabolotnikov assigned RGO230 and unassigned AZabolotnikov Sep 5, 2025

AZabolotnikov mentioned this pull request Sep 5, 2025

159 ability to set nova resource for nova tests generator #165

Closed

RGO230 closed this Sep 5, 2025

RGO230 deleted the 140-use-NovaResource-class-in-NovaTestGenerator-instead-of-Model branch September 5, 2025 10:14

-            $this->isNovaResourceExists();
+            $resource = $this->resourceName ?? $this->getNovaResource();
+            $this->shortNovaResourceName = Str::afterLast($resource, '\\');
+            $this->fullNovaResourcePath = "App\\Nova\\{$resource}";

-    protected function getNovaResource(): ?string
+    protected function getNovaResource(): string
+    {
+        $commonResources = $this->getCommonNovaResources();
+        if (count($commonResources) > 1) {
+            $commonResources = implode(', ', $commonResources);
+            $this->throwFailureException(
+                EntityCreateException::class,
+                "Cannot create Nova{$this->model}Resource Test cause was found a lot of suitable resources: $commonResources",
+                "Please, use --resource-name option"
+            );
+        }
+        return array_pop($commonResources);
+    }

-    protected function getCommonNovaResources(): array
+    protected function getCommonNovaResources(): array
+    {
+        $resources = [];
+        foreach ($this->getNovaFiles() as $file) {
+            $relativePath = Str::after($file->getPathname(), $this->novaPath . DIRECTORY_SEPARATOR);
+            $class = str_replace(['/', '.php'], ['\\', ''], $relativePath);
+            if ($this->isNovaResource($class) && $this->isResourceNameContainModel($class)) {
+                $resources[] = $class;
+            }
+        }
+        return $resources;
+    }

	return app("{$this->fullNovaResourcePath}")->filters(new NovaRequest());
	return app($this->fullNovaResourcePath)->filters(new NovaRequest());

refactor: use resource in generate only nova tests #163

refactor: use resource in generate only nova tests #163

Uh oh!

Conversation

RGO230 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AZabolotnikov commented Sep 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RGO230 commented Jun 25, 2025 •

edited

Loading