Skip to content

Conversation

@AZabolotnikov
Copy link
Contributor

refs: #179

@AZabolotnikov AZabolotnikov self-assigned this Oct 16, 2025
@DenTray DenTray requested a review from Copilot October 20, 2025 05:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the usage of relative file paths in ResourceAlreadyExistsException messages by removing the "vfs://root" prefix from file paths and ensuring consistency with relative paths starting with "/".

Key changes:

  • Updated the EntityGenerator to return relative paths instead of absolute paths from getClassPath()
  • Modified ResourceAlreadyExistsException to prepend "/" to file paths in error messages
  • Updated all test files to expect the new relative path format in exception messages

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

File Description
src/Generators/EntityGenerator.php Modified classExists() and getClassPath() methods to handle relative vs absolute paths properly
src/Exceptions/ResourceAlreadyExistsException.php Added "/" prefix to file path in exception message
tests/*.php Updated test expectations to match new relative path format in exception messages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DenTray DenTray merged commit 145c4d5 into master Oct 20, 2025
4 checks passed
@DenTray DenTray deleted the throw-directly-ResourceAlreadyExistsException branch October 20, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants