[216] convert entity and relation names to PascalCase #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Commands/MakeEntityCommand.php
Outdated
| $this->extractEntityNameAndPath(); | ||
| $this->validateOnlyApiOption(); | ||
| $this->validateCrudOptions(); | ||
| $this->entityName = $this->convertToPascalCase($this->entityName); |
Contributor
There was a problem hiding this comment.
please move it to handle method, because Is not validation operation.
…ntityCommand refs: #216
DenTray
approved these changes
Nov 3, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements automatic conversion of entity and relation names from snake_case/lowercase to PascalCase with informative user feedback. When users provide lowercase entity or relation names, the system now converts them to the proper PascalCase format and displays conversion messages.
Key Changes
- Entity names are now converted to PascalCase in the command handler with user notification
- Relation names are automatically converted to PascalCase during parsing
- Removed premature PascalCase conversion in
EntityGenerator::setModel()to allow proper conversion tracking
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Commands/MakeEntityCommand.php | Added convertToPascalCase() method for standardized case conversion with user notification; renamed trimRelations() to prepareRelations() and integrated conversion logic |
| src/Generators/EntityGenerator.php | Removed Str::studly() conversion from setModel() to defer conversion to the command level |
| tests/ModelGeneratorTest.php | Updated test to verify conversion messages are displayed for entity and relation names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #216