Cover generators with tests #65

KonstantinLapkovsky · 2023-12-15T18:17:57Z

Issue #49

tests/fixtures/ControllerGeneratorTest/api.php

tests/Support/Controller/ControllerMockTrait.php

tests/Support/NovaTest/NovaTestMockTrait.php

tests/Support/Shared/GeneratorMockTrait.php

DenTray · 2023-12-26T05:16:37Z

@KonstantinLapkovsky please check all other mock traits according my comments

# Conflicts: # phpunit.xml # tests/Support/NovaTestMockTrait.php

tests/Support/Shared/GeneratorMockTrait.php

tests/Support/Controller/ControllerMockTrait.php

tests/Support/Shared/GeneratorMockTrait.php

tests/Support/NovaResource/NovaResourceMockTrait.php

tests/Support/NovaTest/NovaTestMockTrait.php

tests/Support/Shared/GeneratorMockTrait.php

phpunit.xml

tests/ControllerGeneratorTest.php

tests/NovaResourceGeneratorTest.php

DenTray · 2024-10-29T06:21:12Z

tests/NovaResourceGeneratorTest.php

+        $this->expectException(ClassNotExistsException::class);
+        $this->expectExceptionMessage('Cannot create Post Nova resource cause Post Model does not exists. '
+            . "Create a Post Model by himself or run command 'php artisan make:entity Post --only-model'");


let's wrap it to the helper

Suggested change

$this->expectException(ClassNotExistsException::class);

$this->expectExceptionMessage('Cannot create Post Nova resource cause Post Model does not exists. '

. "Create a Post Model by himself or run command 'php artisan make:entity Post --only-model'");

$this->assertExceptionThrowed(ClassNotExistsException::class, "Cannot create Post Nova resource cause Post Model does not exists. Create a Post Model by himself or run command 'php artisan make:entity Post --only-model'");

could we use already implemented assertExceptionThrowed helper instead?

tests/NovaTestGeneratorTest.php

tests/TestCase.php

tests/Support/GeneratorMockTrait.php

tests/Support/NovaTestGeneratorTest/NovaTestGeneratorMockTrait.php

DenTray · 2024-11-18T06:35:00Z

tests/NovaResourceGeneratorTest.php

+        $this->expectException(ClassNotExistsException::class);
+        $this->expectExceptionMessage('Cannot create Post Nova resource cause Post Model does not exists. '
+            . "Create a Post Model by himself or run command 'php artisan make:entity Post --only-model'");


could we use already implemented assertExceptionThrowed helper instead?

DenTray · 2024-11-18T06:38:38Z

tests/NovaTestGeneratorTest.php

-    use NovaTestMockTrait;
+    use NovaTestGeneratorMockTrait;

    public function testCreateNovaTestsResourceNotExists()


Suggested change

public function testCreateNovaTestsResourceNotExists()

public function testGenerateResourceNotExists()

DenTray · 2024-11-18T06:39:27Z

tests/NovaTestGeneratorTest.php

+            ->generate();
    }

    public function testCreateNovaTestAlreadyExists()


Suggested change

public function testCreateNovaTestAlreadyExists()

public function testGenerateNovaTestAlreadyExists()

DenTray · 2024-11-18T06:40:27Z

tests/NovaTestGeneratorTest.php

        $this->assertGeneratedFileEquals('update_welcome_bonus_request.json', 'tests/fixtures/NovaWelcomeBonusTest/update_welcome_bonus_request.json');
+    }
+
+    public function testCreateWithMissingNovaPackage()


Suggested change

public function testCreateWithMissingNovaPackage()

public function testGenerateNovaPackageNotInstall()

DenTray · 2024-11-18T06:42:54Z

tests/Support/GeneratorMockTrait.php

+
+    public function mockCheckingNovaPackageExistence(string $className, bool $result = false): void
+    {
+        $this->mockClassExistsFunction($className, $result);
+    }


seems this method is not using anymore

Suggested change

public function mockCheckingNovaPackageExistence(string $className, bool $result = false): void

{

$this->mockClassExistsFunction($className, $result);

}

DenTray · 2024-11-18T06:46:27Z

src/Generators/NovaResourceGenerator.php

    }

-    protected function getFieldsForCreation(): array
+    public function getFieldsForCreation(): array


should we change visibility for this function?

DenTray · 2024-11-18T06:54:31Z

tests/NovaResourceGeneratorTest.php

+use Doctrine\DBAL\Types\IntegerType;
+use Doctrine\DBAL\Types\StringType;
+use Illuminate\Support\Facades\Event;
+use ReflectionClass;


Suggested change

use ReflectionClass;

- minor fixes - removed unused methods - use WelcomeBonusResource instead mocking NovaTestGenerator

src/Generators/AbstractTestsGenerator.php

tests/Support/NovaTestGeneratorTest/NovaTestGeneratorMockTrait.php

tests/NovaTestGeneratorTest.php

Konstantin Lapkovsky added 6 commits December 15, 2023 13:40

chore: remove redundant logic.

8f76f20

test: add Nova test generator test case.

aaf4e67

test: separate tests for Nova Resources and Nova tests.

76dba4c

Merge branch '42-extend-nova-resource-generator' into 49-add-tests

1605125

test: add tests for Nova Resource.

dfb9d07

test: add fixture.

ac6845c

KonstantinLapkovsky requested a review from DenTray December 15, 2023 18:17

KonstantinLapkovsky self-assigned this Dec 15, 2023

test: add tests for controller generator.

c20b26f

KonstantinLapkovsky changed the base branch from master to 49-cover-entity-generator-with-tests December 18, 2023 08:02

KonstantinLapkovsky assigned DenTray and unassigned KonstantinLapkovsky Dec 20, 2023

Merge branch 'master' into 49-add-tests

fa2c9f7

KonstantinLapkovsky changed the base branch from 49-cover-entity-generator-with-tests to master December 20, 2023 08:11

KonstantinLapkovsky changed the base branch from master to 49-cover-entity-generator-with-tests December 20, 2023 08:11

chore: remove useless methods.

5fa7683

DenTray requested changes Dec 26, 2023

View reviewed changes

tests/fixtures/ControllerGeneratorTest/api.php Show resolved Hide resolved

tests/Support/Controller/ControllerMockTrait.php Outdated Show resolved Hide resolved

tests/Support/NovaTest/NovaTestMockTrait.php Outdated Show resolved Hide resolved

DenTray requested changes Dec 26, 2023

View reviewed changes

tests/Support/Shared/GeneratorMockTrait.php Outdated Show resolved Hide resolved

DenTray assigned KonstantinLapkovsky and unassigned DenTray Dec 26, 2023

Konstantin Lapkovsky added 3 commits January 18, 2024 14:39

test: correct test functions.

0443851

Merge branch 'master' into 49-add-tests

2933b28

# Conflicts: # phpunit.xml # tests/Support/NovaTestMockTrait.php

test: correct tests.

193ab1b

KonstantinLapkovsky assigned DenTray and unassigned KonstantinLapkovsky Jan 18, 2024

KonstantinLapkovsky changed the base branch from 49-cover-entity-generator-with-tests to master January 18, 2024 13:02

KonstantinLapkovsky changed the base branch from master to 49-cover-entity-generator-with-tests January 18, 2024 13:02

DenTray requested changes Jan 22, 2024

View reviewed changes

DenTray assigned KonstantinLapkovsky Jan 22, 2024

aizlee assigned DenTray and unassigned aizlee Oct 28, 2024

chore: remove unsed rollbackToDefaultBasePath

7a4ee58

DenTray requested changes Oct 29, 2024

View reviewed changes

DenTray assigned aizlee and unassigned DenTray Oct 29, 2024

aizlee added 10 commits November 12, 2024 13:53

refactor: mockNovaResourceTestGenerator

75d27c6

chore: updated packages versions

1274250

chore: merge with master

ecb4217

chore: updated packages versions

e160b0e

chore: remove debug

e789a97

feat: implemneted assertEventPushedChain

10c9bab

feat: implemented assertExceptionThrowed

80d7b2c

fix: remove reflection from NovaResourceGeneratorTest

61b547a

chore: update laravel to v11.31

749a6e7

chore: composer update

8384c61

aizlee assigned DenTray and unassigned aizlee Nov 15, 2024

DenTray requested changes Nov 18, 2024

View reviewed changes

DenTray removed their assignment Nov 18, 2024

DenTray requested changes Nov 18, 2024

View reviewed changes

DenTray assigned aizlee Nov 18, 2024

fix:

3f38dbd

- minor fixes - removed unused methods - use WelcomeBonusResource instead mocking NovaTestGenerator

DenTray requested changes Nov 18, 2024

View reviewed changes

src/Generators/AbstractTestsGenerator.php Outdated Show resolved Hide resolved

Update src/Generators/AbstractTestsGenerator.php

a0c694c

DenTray approved these changes Nov 18, 2024

View reviewed changes

tests/Support/NovaTestGeneratorTest/NovaTestGeneratorMockTrait.php Outdated Show resolved Hide resolved

tests/NovaTestGeneratorTest.php Outdated Show resolved Hide resolved

Apply suggestions from code review

30d2f74

DenTray approved these changes Nov 18, 2024

View reviewed changes

DenTray merged commit a22d3a2 into master Nov 18, 2024
2 checks passed

DenTray deleted the 49-add-tests branch July 8, 2025 08:40

	public function testCreateNovaTestsResourceNotExists()
	public function testGenerateResourceNotExists()

	public function testCreateNovaTestAlreadyExists()
	public function testGenerateNovaTestAlreadyExists()

	public function testCreateWithMissingNovaPackage()
	public function testGenerateNovaPackageNotInstall()

Cover generators with tests #65

Cover generators with tests #65

Uh oh!

Conversation

KonstantinLapkovsky commented Dec 15, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DenTray commented Dec 26, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants