Add migration generator tests #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonstantinLapkovsky
changed the base branch from
master
to
49-cover-entity-generator-with-tests
# Conflicts: # phpunit.xml # tests/Support/NovaTestMockTrait.php
KonstantinLapkovsky
changed the base branch from
49-cover-entity-generator-with-tests
to
master
KonstantinLapkovsky
changed the base branch from
master
to
49-cover-entity-generator-with-tests
AZabolotnikov
changed the base branch from
49-cover-entity-generator-with-tests
to
master
# Conflicts: # phpunit.xml # tests/Support/NovaTestMockTrait.php # tests/TestCase.php
DenTray
reviewed
Nov 26, 2024
Collaborator
DenTray
left a comment
DenTray
left a comment
There was a problem hiding this comment.
let's return to this after factory pull request will be mnerged
refs: #49
DenTray
requested changes
Dec 11, 2024
| } | ||
|
|
||
| throw new Exception('Unknown fieldType in MigrationGenerator'); | ||
| throw new UnknownFieldTypeException("Unknown field type {$typeName} in MigrationGenerator."); |
Collaborator
There was a problem hiding this comment.
let's move message generation into the exception class
Suggested change
| throw new UnknownFieldTypeException("Unknown field type {$typeName} in MigrationGenerator."); | |
| throw new UnknownFieldTypeException($typeName, 'MigrationGenerator'); |
tests/MigrationGeneratorTest.php
Outdated
Comment on lines
19
to
20
| $this->expectException(UnknownFieldTypeException::class); | ||
| $this->expectExceptionMessage('Unknown field type unknown-type in MigrationGenerator.'); |
Collaborator
There was a problem hiding this comment.
please use assertExceptionThrew helper
tests/MigrationGeneratorTest.php
Outdated
| $this->assertGeneratedFileEquals('migrations.php', 'database/migrations/2022_02_02_000000_posts_create_table.php'); | ||
| } | ||
|
|
||
| public function testMethodForMYSQLConnection() |
Collaborator
There was a problem hiding this comment.
please just check mysql driver using separate fixture of resulted dump
DenTray
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #49