Add repository generator tests #73
Merged
+107
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 21, 2023 13:53
# Conflicts: # phpunit.xml # tests/Support/NovaTestMockTrait.php
KonstantinLapkovsky
changed the base branch from
master
to
49-cover-entity-generator-with-tests
…to 49-add-repository-generator-tests # Conflicts: # phpunit.xml # tests/FactoryGeneratorTest.php # tests/Support/NovaTest/NovaTestMockTrait.php
refs: #49
…into 49-add-repository-generator-tests # Conflicts: # tests/Support/NovaTest/NovaTestMockTrait.php
refs: #49
…to 49-add-repository-generator-tests # Conflicts: # tests/Support/NovaTest/NovaTestMockTrait.php
pirs1337
changed the base branch from
49-cover-entity-generator-with-tests
to
master
refs: #49
Collaborator
|
@pirs1337 please assign this one after merging model generation test |
…to 49-add-repository-generator-tests
refs: #49
…s' into 49-add-repository-generator-tests
…to 49-add-repository-generator-tests
…to 49-add-repository-generator-tests
DenTray
reviewed
Jan 14, 2025
tests/RepositoryGeneratorTest.php
Outdated
|
|
||
| $this->assertExceptionThrew( | ||
| className: ClassNotExistsException::class, | ||
| message: "Cannot create Post Model cause Post Model does not exists. " |
Collaborator
There was a problem hiding this comment.
please check exception message, seems we need to throw next text
Suggested change
| message: "Cannot create Post Model cause Post Model does not exists. " | |
| message: "Cannot create PostRepository cause Post Model does not exists. " |
|
|
||
| trait RepositoryMockTrait | ||
| { | ||
| use GeneratorMockTrait, MockTrait; |
Collaborator
There was a problem hiding this comment.
could GeneratorMockTrait use MockTrait directly?
refs: #49
DenTray
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #49