-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: first stage of ReadmeGenerator init #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 19028578565Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Refactors README generation by extracting logic from InitCommand into a dedicated ReadmeGenerator and updates tests to mock I/O at the Generators namespace level.
- Introduces ReadmeGenerator with responsibilities for assembling and saving README content.
- Refactors InitCommand to delegate README-related operations to ReadmeGenerator.
- Updates tests to mock file_get_contents and file_put_contents calls within the Generators namespace.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Generators/ReadmeGenerator.php | New class encapsulating README generation and file operations. |
| src/Commands/InitCommand.php | Delegates README steps to ReadmeGenerator; removes inlined README helpers. |
| tests/InitCommandTest.php | Switches to mocking native functions in the Generators namespace and adjusts expectations. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/Commands/InitCommand.php:1
- Inconsistent indentation: this line has 3 spaces of indentation instead of the standard 12 spaces used by surrounding lines. This should be aligned with the other lines in this mock function call.
<?php
src/Commands/InitCommand.php:1
- Trailing whitespace detected at the end of this line. This should be removed to maintain clean code formatting.
<?php
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refs: #67