[55] fix admin name question option #75

neellii · 2025-10-24T04:03:45Z

refs: #55

coveralls · 2025-10-24T04:05:50Z

Pull Request Test Coverage Report for Build 19160147855

Details

6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 98.438%

Totals
Change from base Build 19103726582:	0.01%
Covered Lines:	315
Relevant Lines:	320

💛 - Coveralls

Copilot

Pull Request Overview

This PR refactors the createAdminUser method to improve code clarity and consistency by extracting the service admin check into a dedicated boolean variable. The logic remains functionally equivalent but becomes more readable and maintainable.

Key Changes:

Introduced $isServiceAdmin boolean variable to consolidate the service admin check
Updated all conditional expressions to use the new variable instead of redundant checks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Commands/InitCommand.php

DenTray

@neellii please try to cover changed logic by autotests

DenTray · 2025-11-03T15:08:39Z

src/Commands/InitCommand.php


        if ($this->authType === AuthTypeEnum::None) {
-            $adminCredentials['name'] = $this->ask("Please enter admin name{$serviceLabel}", "{$serviceName} Admin");
+            $adminCredentials['name'] = $this->ask("Please enter admin name{$serviceLabel}", when($isServiceAdmin, "{$serviceName} Admin", 'Admin'));


let's move default name generation to the separate variable

refs: #55

Copilot

Pull Request Overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-10T05:09:41Z

tests/fixtures/InitCommandTest/none_auth_default_admins_credentials_readme.md

+
+Below are links to tools and services used in this project:
+- [Laravel Telescope](): This is debug assistant for the Laravel framework. (will be added later)
+- [Laravel Nova](): This is admin panel for the Laravel framework. (will be added later)


Missing article 'an' before 'admin panel'. Should be "This is an admin panel for the Laravel framework."

Suggested change

- [Laravel Nova](): This is admin panel for the Laravel framework. (will be added later)

- [Laravel Nova](): This is an admin panel for the Laravel framework. (will be added later)

Copilot · 2025-11-10T05:09:41Z

tests/fixtures/InitCommandTest/clerk_auth_default_admins_credentials_readme.md

+### Resources
+
+Below are links to tools and services used in this project:
+- [Laravel Telescope](): This is debug assistant for the Laravel framework. (will be added later)


Missing article 'a' before 'debug assistant'. Should be "This is a debug assistant for the Laravel framework."

Suggested change

- [Laravel Telescope](): This is debug assistant for the Laravel framework. (will be added later)

- [Laravel Telescope](): This is a debug assistant for the Laravel framework. (will be added later)

Copilot · 2025-11-10T05:09:42Z

tests/fixtures/InitCommandTest/clerk_auth_default_admins_credentials_readme.md

+
+Below are links to tools and services used in this project:
+- [Laravel Telescope](): This is debug assistant for the Laravel framework. (will be added later)
+- [Laravel Nova](): This is admin panel for the Laravel framework. (will be added later)


Missing article 'an' before 'admin panel'. Should be "This is an admin panel for the Laravel framework."

Suggested change

- [Laravel Nova](): This is admin panel for the Laravel framework. (will be added later)

- [Laravel Nova](): This is an admin panel for the Laravel framework. (will be added later)

Copilot · 2025-11-10T05:09:42Z

src/Commands/InitCommand.php

        $defaultPassword = substr(md5(uniqid()), 0, 8);

-        $serviceLabel = when(!empty($serviceName), " for {$serviceName}");
+        $serviceLabel = when($isServiceAdmin, " for {$serviceName}");


The when() helper on this line is missing the third parameter (default value). When $isServiceAdmin is false, this will return null instead of an empty string. This could result in the service label being null rather than empty, which may cause type inconsistencies or unexpected output.

Consider changing to:

$serviceLabel = when($isServiceAdmin, " for {$serviceName}", '');

Suggested change

$serviceLabel = when($isServiceAdmin, " for {$serviceName}");

$serviceLabel = when($isServiceAdmin, " for {$serviceName}", '');

Copilot · 2025-11-10T05:09:42Z

tests/InitCommandTest.php

            ->assertExitCode(0);
    }
+
+    public function testDefaultAdminsCredentialsNoneAuth()


Test method is missing the : void return type declaration. For consistency with other recently added test methods in this file (like testRunWithClerkMobileAppWithPintInstalled and testRunWithClerkAdditionalAdminsWithoutDefaultAdmin), this method should include the return type.

Add : void after the method signature:

public function testDefaultAdminsCredentialsNoneAuth(): void

Suggested change

public function testDefaultAdminsCredentialsNoneAuth()

public function testDefaultAdminsCredentialsNoneAuth(): void

Copilot · 2025-11-10T05:09:43Z

tests/InitCommandTest.php

+        ]);
+    }
+
+    public function testDefaultAdminsCredentialsClerkAuth()


Test method is missing the : void return type declaration. For consistency with other recently added test methods in this file (like testRunWithClerkMobileAppWithPintInstalled and testRunWithClerkAdditionalAdminsWithoutDefaultAdmin), this method should include the return type.

Add : void after the method signature:

public function testDefaultAdminsCredentialsClerkAuth(): void

Suggested change

public function testDefaultAdminsCredentialsClerkAuth()

public function testDefaultAdminsCredentialsClerkAuth(): void

Copilot · 2025-11-10T05:09:43Z

tests/fixtures/InitCommandTest/none_auth_default_admins_credentials_readme.md

+### Resources
+
+Below are links to tools and services used in this project:
+- [Laravel Telescope](): This is debug assistant for the Laravel framework. (will be added later)


Missing article 'a' before 'debug assistant'. Should be "This is a debug assistant for the Laravel framework."

Suggested change

- [Laravel Telescope](): This is debug assistant for the Laravel framework. (will be added later)

- [Laravel Telescope](): This is a debug assistant for the Laravel framework. (will be added later)

DenTray · 2025-11-10T05:12:48Z

@neellii please fix tests

fix: fix admin name option

793d3ed

refs: #55

neellii assigned DenTray and AZabolotnikov and unassigned DenTray Oct 24, 2025

AZabolotnikov assigned DenTray and unassigned AZabolotnikov Oct 28, 2025

Merge branch 'main' into 55-admin-name-fix

d958860

DenTray requested a review from Copilot November 3, 2025 13:04

Copilot AI reviewed Nov 3, 2025

View reviewed changes

src/Commands/InitCommand.php Show resolved Hide resolved

DenTray reviewed Nov 3, 2025

View reviewed changes

DenTray assigned neellii and unassigned DenTray Nov 3, 2025

DenTray and others added 6 commits November 4, 2025 13:55

Merge branch 'main' into 55-admin-name-fix

cc56666

refactor: clean createAdminUser method, add tests

02d8964

refs: #55

chore: merge with origin

c7014a4

test: fix tests

e2ab430

refs: #55

chore: merge with main

6c7eb99

test: fix tests

6986207

refs: #55

neellii assigned DenTray and unassigned neellii Nov 7, 2025

Merge branch 'main' into 55-admin-name-fix

7bd4375

DenTray requested a review from Copilot November 10, 2025 05:06

Copilot AI reviewed Nov 10, 2025

View reviewed changes

DenTray assigned neellii and unassigned DenTray Nov 10, 2025

	- [Laravel Nova](): This is admin panel for the Laravel framework. (will be added later)
	- [Laravel Nova](): This is an admin panel for the Laravel framework. (will be added later)

	- [Laravel Telescope](): This is debug assistant for the Laravel framework. (will be added later)
	- [Laravel Telescope](): This is a debug assistant for the Laravel framework. (will be added later)

	$serviceLabel = when($isServiceAdmin, " for {$serviceName}");
	$serviceLabel = when($isServiceAdmin, " for {$serviceName}", '');

	public function testDefaultAdminsCredentialsNoneAuth()
	public function testDefaultAdminsCredentialsNoneAuth(): void

[55] fix admin name question option #75

Are you sure you want to change the base?

[55] fix admin name question option #75

Conversation

neellii commented Oct 24, 2025

Uh oh!

coveralls commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 19160147855

Details

💛 - Coveralls

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

DenTray left a comment

Choose a reason for hiding this comment

Uh oh!

DenTray Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

DenTray commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Oct 24, 2025 •

edited

Loading