This repository was archived by the owner on Jun 3, 2024. It is now read-only.

#2 No need to merge, submission for code challenge 👾 #2

Open

nimble-123 wants to merge 6 commits into SAP-archive:main from nimble-123:main

nimble-123 commented Feb 14, 2022 •

edited

Loading

What i've done so far:

switched to yarn as package/dependency manager
added missing Typescript types via awesome DefinitelyTyped (@types) project
enhanced yarn scripts
added Prettier for code formatting
fixed typo in border.png filename
moved UI translation texts to app i18n files
fixed UI namespace
ported UI from JavaScript to Typescript
removed unnecessary console.log() occurrences
switched to SAP Horizon theme

What's missing from my pov:

port Express API to Typescript as well
create MTA descriptor for easy deployment to BTP CF
create Docker container and K8s scripts for easy deployment to BTP Kyma
deep dive to watch out for more hints placed by Thomas 😉

Nils Lutz added 6 commits

February 14, 2022 22:02


          refactor: switch to yarn

c0d89c6


          refactor: add prettier and missing TS types

0cdf4b0

enhance yarn script as well


          fix: rename border image asset filename

1bf5834


          refactor: keep only API relevant translation texts

9cf0eec

UI translation texts will be stored in app i18n files


          feat: port UI app to Typescript

79e7984


          fix: change path to Typescript config for UI5 app

e5cd27e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet