-
Notifications
You must be signed in to change notification settings - Fork 19
468 ABM parameter study #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
468 ABM parameter study #1395
Conversation
…nto abm-parameter-study
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1395 +/- ##
========================================
Coverage 97.25% 97.25%
========================================
Files 176 182 +6
Lines 15466 15662 +196
========================================
+ Hits 15041 15232 +191
- Misses 425 430 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
this allows deduction of template arguments from the constructor, making the make_parameter_study functions obsolete. the simulation type is now deduced from the create_simulation argument, and checks on invocability have been moved to clean up deduced types. Add documentation.
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
Co-authored-by: annawendler <106674756+annawendler@users.noreply.github.com>
MaxBetzDLR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes for documentation of python bindings
pycode/memilio-simulation/memilio/simulation/bindings/models/osecir.cpp
Outdated
Show resolved
Hide resolved
MaxBetzDLR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)