Skip to content

Use WarnLevel instead of ErrorLevel for Blas messages by default #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
+15 −15
Merged

Use WarnLevel instead of ErrorLevel for Blas messages by default #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e107ba
change errors to warnlevel
jClugstor Nov 20, 2025
77330fe
remove unused ErrorLevel export
jClugstor Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LinearSolve.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ using SciMLOperators: SciMLOperators, AbstractSciMLOperator, IdentityOperator,
MatrixOperator,
has_ldiv!, issquare
using SciMLLogging: SciMLLogging, @SciMLMessage, verbosity_to_int, AbstractVerbositySpecifier, AbstractMessageLevel, AbstractVerbosityPreset,
Silent, InfoLevel, WarnLevel, ErrorLevel, CustomLevel, None, Minimal, Standard, Detailed, All
Silent, InfoLevel, WarnLevel, CustomLevel, None, Minimal, Standard, Detailed, All
using Setfield: @set, @set!
using UnPack: @unpack
using DocStringExtensions: DocStringExtensions
Expand Down
20 changes: 10 additions & 10 deletions src/verbosity.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ function LinearVerbosity(;
Silent(),
InfoLevel(),
Silent(),
ErrorLevel(),
ErrorLevel(),
WarnLevel(),
WarnLevel(),
Silent(),
Silent(),
Silent(),
Expand Down Expand Up @@ -148,8 +148,8 @@ function LinearVerbosity(;
KrylovJL_verbosity = Silent(),
HYPRE_verbosity = InfoLevel(),
pardiso_verbosity = Silent(),
blas_errors = ErrorLevel(),
blas_invalid_args = ErrorLevel(),
blas_errors = WarnLevel(),
blas_invalid_args = WarnLevel(),
blas_info = Silent(),
blas_success = Silent(),
condition_number=Silent(),
Expand Down Expand Up @@ -193,8 +193,8 @@ function LinearVerbosity(verbose::AbstractVerbosityPreset)
KrylovJL_verbosity = Silent(),
HYPRE_verbosity = Silent(),
pardiso_verbosity = Silent(),
blas_errors = ErrorLevel(),
blas_invalid_args = ErrorLevel(),
blas_errors = WarnLevel(),
blas_invalid_args = WarnLevel(),
blas_info = Silent(),
blas_success = Silent(),
condition_number = Silent(),
Expand All @@ -216,8 +216,8 @@ function LinearVerbosity(verbose::AbstractVerbosityPreset)
KrylovJL_verbosity = CustomLevel(1), # verbose = true in Krylov.jl
HYPRE_verbosity = InfoLevel(),
pardiso_verbosity = CustomLevel(1), # verbose = true in Pardiso.jl
blas_errors = ErrorLevel(),
blas_invalid_args = ErrorLevel(),
blas_errors = WarnLevel(),
blas_invalid_args = WarnLevel(),
blas_info = InfoLevel(),
blas_success = InfoLevel(),
condition_number = Silent(),
Expand All @@ -236,8 +236,8 @@ function LinearVerbosity(verbose::AbstractVerbosityPreset)
KrylovJL_verbosity = CustomLevel(1),
HYPRE_verbosity = InfoLevel(),
pardiso_verbosity = CustomLevel(1), # verbsoe = true in Pardiso.jl
blas_errors = ErrorLevel(),
blas_invalid_args = ErrorLevel(),
blas_errors = WarnLevel(),
blas_invalid_args = WarnLevel(),
blas_info = InfoLevel(),
blas_success = InfoLevel(),
condition_number = InfoLevel(),
Expand Down
8 changes: 4 additions & 4 deletions test/verbosity.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ using Test
end

@testset "Group-level keyword constructors" begin
v4_error = LinearVerbosity(error_control = ErrorLevel())
v4_error = LinearVerbosity(error_control = SciMLLogging.ErrorLevel())
@test v4_error.default_lu_fallback isa SciMLLogging.ErrorLevel

v4_numerical = LinearVerbosity(numerical = Silent())
Expand Down Expand Up @@ -53,9 +53,9 @@ using Test

@testset "Individual keyword arguments" begin
v6_individual = LinearVerbosity(
default_lu_fallback = ErrorLevel(),
KrylovKit_verbosity = InfoLevel(),
pardiso_verbosity = Silent()
default_lu_fallback = SciMLLogging.ErrorLevel(),
KrylovKit_verbosity = SciMLLogging.InfoLevel(),
pardiso_verbosity = SciMLLogging.Silent()
)
@test v6_individual.default_lu_fallback isa SciMLLogging.ErrorLevel
@test v6_individual.KrylovKit_verbosity isa SciMLLogging.InfoLevel
Expand Down
Loading