Skip to content

fix: fix prohibitively narrow type annotations in SCCNonlinearProblem #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
+5 −5
Merged

fix: fix prohibitively narrow type annotations in SCCNonlinearProblem #4038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/problems/sccnonlinearproblem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
const TypeT = Union{DataType, UnionAll}

struct CacheWriter{F}
fn::F
end
Expand Down Expand Up @@ -161,8 +159,8 @@ function SciMLBase.SCCNonlinearProblem{iip}(sys::System, op; eval_expression = f
end

# map from symtype to cached variables and their expressions
cachevars = Dict{Union{DataType, UnionAll}, Vector{Any}}()
cacheexprs = Dict{Union{DataType, UnionAll}, Vector{Any}}()
cachevars = Dict{TypeT, Vector{Any}}()
cacheexprs = Dict{TypeT, Vector{Any}}()
# observed of previous SCCs are in the cache
# NOTE: When we get proper CSE, we can substitute these
# and then use `subexpressions_not_involving_vars!`
Expand Down
4 changes: 3 additions & 1 deletion src/systems/index_cache.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
const TypeT = Union{DataType, UnionAll, Union}

struct BufferTemplate
type::Union{DataType, UnionAll, Union}
type::TypeT
length::Int
end

Expand Down
Loading