Skip to content

fix: minor fixes for clock stuff #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −1
Open

fix: minor fixes for clock stuff #4041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d660ec
fix: consider `Hold` and `Sample` as parameters in `process_parameter…
AayushSabharwal Dec 3, 2025
b29aa5d
fix: `Hold(::Number)` should passthrough
AayushSabharwal Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/discretedomain.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ end
is_transparent_operator(::Type{Hold}) = true

(D::Hold)(x) = Term{symtype(x)}(D, Any[x])
(D::Hold)(x::Number) = x
Copy link
Member

@ChrisRackauckas ChrisRackauckas Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does this come up?

Copy link
Member Author

@AayushSabharwal AayushSabharwal Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fixpoint_sub when building MTKParameters. Hold(x) is stored as a parameter, so an initial value for x is an initial value for Hold(x).

(D::Hold)(x::Num) = Num(D(value(x)))
SymbolicUtils.promote_symtype(::Hold, x) = x
Base.nameof(::Hold) = :Hold
Expand Down
2 changes: 1 addition & 1 deletion src/systems/abstractsystem.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2796,7 +2796,7 @@ function process_parameter_equations(sys::AbstractSystem)
eqs = equations(sys)
for (i, eq) in enumerate(eqs)
empty!(varsbuf)
vars!(varsbuf, eq; op = Union{Differential, Initial, Pre})
vars!(varsbuf, eq; op = Union{Differential, Initial, Pre, Hold, Sample})
# singular equations
isempty(varsbuf) && continue
if all(varsbuf) do sym
Expand Down
Loading