Bug: Put contentRef in state to let EventStack track changes #4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contentRef is passed to EventStack to subscribe for mouse events. Passing a `contentRef` created using `React.createRef()` does not allow EventStack to keep track of contentRef changes (since only contentRef.current changes). Ultimately when PortalInner unmount contentRef.current is set to undefined and EventStack `unsubscribe` handlers with `undefined` as a target instead of unsubscribing with real content. This leads to the event-stack Map keeping a reference to the real contentRef thus leaking all dom tree related to the node related to contentRef. Putting contentRef in the state and passing the element allow for EventStack to detect change in props and execute the componentDidUpdate routine which unsubscribe from the previous element on unmount.
|
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contentRef is passed to EventStack to subscribe for mouse events.
Passing a
contentRefcreated usingReact.createRef()does not allow EventStack to keep track of contentRef changes (since onlycontentRef.currentchanges).Ultimately when PortalInner unmount
contentRef.currentis set to undefined and EventStackunsubscribehandlers withundefinedas a target instead of unsubscribing with real content. This leads to the event-stack Map keeping a reference to the real content thus leaking all dom tree related to the contentRef node.Putting contentRef in the state and passing the element directly to EventStack allow for EventStack to detect change in its props and execute the componentDidUpdate routine which unsubscribe from the previous element on unmount.