Skip to content

BUG: Report error if --python-script associated with non-existent file #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BUG: Report error if --python-script associated with non-existent file #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Applications/SlicerApp/Testing/Python/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,13 @@ slicer_add_python_test(SCRIPT SlicerTestingExitSuccessTest.py)
slicer_add_python_test(SCRIPT SlicerTestingExitFailureTest.py)
set_tests_properties(py_SlicerTestingExitFailureTest PROPERTIES WILL_FAIL TRUE)

slicer_add_python_test(
SCRIPT SlicerTestingWithNonExistentScriptTest.py
SLICER_ARGS --no-main-window --disable-modules --exit-after-startup
TESTNAME_PREFIX nomainwindow_
)
set_tests_properties(py_nomainwindow_SlicerTestingWithNonExistentScriptTest PROPERTIES WILL_FAIL TRUE)

#
# Check if 'slicer.testing.runUnitTest()' works as expected
#
Expand Down
5 changes: 3 additions & 2 deletions Base/QTCore/qSlicerCoreApplication.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,14 +928,15 @@ void qSlicerCoreApplication::handleCommandLineArguments()
// Execute python script
if(!pythonScript.isEmpty())
{
qApp->processEvents();
if (QFile::exists(pythonScript))
{
qApp->processEvents();
this->corePythonManager()->executeFile(pythonScript);
}
else
{
qWarning() << "Specified python script doesn't exist:" << pythonScript;
this->corePythonManager()->executeString(
QString("raise RuntimeError(\"Specified python script doesn't exist: %1\")").arg(pythonScript));
}
}
QString pythonCode = options->pythonCode();
Expand Down