fix: robust changed file detection for PRs/MRs in GitHub, GitLab, and… #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Bitbucket - Use git diff with appropriate refs and environment variables to detect changed files in pull/merge requests across GitHub Actions, GitLab CI, and Bitbucket Pipelines. - Fallback to git show for single commit detection. - Ensures manifest and other file changes are correctly picked up in all major
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.33.dev1Docker image: |
reberhardt7
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where manifest and other file changes in pull/merge requests were not detected in CI environments (GitHub Actions, GitLab CI, Bitbucket Pipelines), causing the CLI to miss important file changes in PR/MR workflows.
Root Cause
The previous implementation only used
git showon a single commit (often a merge commit in CI), which does not list all files changed in a PR/MR. This resulted in missing file changes, especially for manifest files, when running in CI environments for pull/merge requests.Fix
The detection logic now checks for PR/MR context in GitHub, GitLab, and Bitbucket using their respective environment variables. It uses
git diffwith the correct base and head refs to get the full list of changed files in a PR/MR. If not in a PR/MR context, it falls back to the originalgit showlogic for single commits.Public Changelog
N/A