Skip to content

Conversation

@dacoburn
Copy link
Collaborator

Issue where manifestFiles can be non-existent with top_level packages. This can cause the CLI to error out incorrectly.

Root Cause

Some results from the diff endpoint can have package entries where the top level package does not have the manifestFiles attribute. The code was not accounting for this correctly.

Fix

Added an explicit check to account for this:

if hasattr(top_package, "manifestFiles") and top_package.manifestFiles:

Public Changelog

  • Added fix for if manifestFiles attribute is not present on a top level package

@dacoburn dacoburn added the Product Changelog New features for the public changelog label Feb 19, 2025
@dacoburn dacoburn requested a review from a team as a code owner February 19, 2025 19:56
@dacoburn dacoburn requested review from mikolalysenko and tmpvar and removed request for a team February 19, 2025 19:56
@github-actions
Copy link

github-actions bot commented Feb 19, 2025

🚀 Preview package published!

Install with:

pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.0.6.dev564

Docker image: socketdev/cli:pr-56

@dacoburn dacoburn merged commit 7b7089e into main Feb 19, 2025
6 checks passed
@dacoburn dacoburn deleted the doug/fix-manifest-issue branch February 19, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product Changelog New features for the public changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants