Add similarity_method param in automerge and fix multi-segment cross-contamination #4201
+100
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks good! Could you add a multi-segment test to (The current tests are a bit messy, I don't know why we need to keep recomputing analyzers when we have a fixture. Also the default analyzer is pretty long (5mins) so the tests are quite long -- 30s locally) |
samuelgarcia
reviewed
Nov 6, 2025
Member
|
Why having a CC by segment ? what is the rational behing this ? |
Co-authored-by: Chris Halcrow <57948917+chrishalcrow@users.noreply.github.com>
…into automerge-fixes
alejoe91
commented
Nov 12, 2025
|
|
||
| unit_id1 = unit_ids[unit_ind1] | ||
| spike_train1 = np.array(sorting.get_unit_spike_train(unit_id1)) | ||
| for segment_index in range(num_segments): |
Member
Author
There was a problem hiding this comment.
instead of doing this, concatenate_sortings
samuelgarcia
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.