Deal with batch_downsampling in kilosort4.1.2 #4206
Merged
+39
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishalcrow
commented
Nov 7, 2025
alejoe91
reviewed
Nov 10, 2025
alejoe91
approved these changes
Nov 10, 2025
chrishalcrow
commented
Nov 10, 2025
Contributor
|
Hi, this fix seems to be quite important, as kilosort is used by many researchers. Our projects auto test units are continuing failing on I am wondering if the maintainance team can release an expedited release. |
Member
|
I'm ok in cutting a new minor release soon. We have some major PRs that refactor some aspects of the postprocessing module, but they can wait. @chrishalcrow @samuelgarcia maybe next week for a 0.103.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4205
KS4.1.2 added a new option,
batch_downsampling. This changes the number of options, and breaks our implementation. This PR deals with it.We could allow users to pass the
batch_downsampling, but KS docs say: "In general, this should be left as the default (using all batches)". So maybe we shouldn't?