Add Tarjan's strongly connected components algorithm #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please fix 17 issues Codacy found |
- Add curly braces to all single-statement blocks - Fix naming conventions: GetSCCCount -> GetSccCount, InSameSCC -> InSameScc, GetSCC -> GetScc - Add meaningful exception message to ArgumentOutOfRangeException - Split multi-statement lines into separate lines - Update all test method names to match renamed methods
Contributor
Author
|
@siriak I've fixed all issues what Codacy found, please check it again, Thanks. |
Member
|
Please check build errors |
0xsatoshi99
force-pushed
the
add-tarjan-scc
branch
from
0072c6a to
2f838fb
Compare
Graph has 3 SCCs not 2:
- SCC 1: {0, 1} (cycle 0→1→0)
- SCC 2: {2} (single node)
- SCC 3: {3, 4, 5} (cycle 3→4→5→3)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 96.87% 96.88% +0.01%
==========================================
Files 290 291 +1
Lines 11920 12035 +115
Branches 1720 1740 +20
==========================================
+ Hits 11547 11660 +113
Misses 237 237
- Partials 136 138 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@siriak Seems like all tests are gone correctly. Please check it. |
siriak
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Tarjan's algorithm for finding strongly connected components in directed graphs.
Features:
Contribution by Gittensor, learn more at https://gittensor.io/