Skip to content

logical change in binary search's bisect left and right's "hi" limit #13898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
+2 −2
Closed

logical change in binary search's bisect left and right's "hi" limit #13898

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e109908
logical change in binary search's bisect left and right's "hi" limit
Nisarg-patel-2410 Nov 11, 2025
c9679e3
adding the comment about negative indexing for hi
Nisarg-patel-2410 Nov 11, 2025
695d404
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 11, 2025
c9d7c02
logical error solving in the binary_search bisecgt_left's hi parameter
Nisarg-patel-2410 Nov 11, 2025
e67dac9
Merge branch 'master' of https://github.com/Nisarg-patel-2410/Python_…
Nisarg-patel-2410 Nov 11, 2025
f40e763
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions searches/binary_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def bisect_left(
2
"""
if hi < 0:
hi = len(sorted_collection)
hi = len(sorted_collection) + hi # in case of usage of negative indexing for hi

while lo < hi:
mid = lo + (hi - lo) // 2
Expand Down Expand Up @@ -86,7 +86,7 @@ def bisect_right(
2
"""
if hi < 0:
hi = len(sorted_collection)
hi = len(sorted_collection) + hi # in case of usage of negative indexing for hi

while lo < hi:
mid = lo + (hi - lo) // 2
Expand Down
Loading