fix(ui5-toolbar-select): add invalidateOnChildChange #12676
+67
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges programmatically
Collaborator
|
🚀 Deployed on https://pr-12676--ui5-webcomponents-preview.netlify.app |
NakataCode
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When programmatically changing the selected property on a ToolbarSelectOption, the ToolbarSelect component's display was not updating to reflect the change.
This occurred because the ToolbarSelect was not invalidating and re-rendering when its child options' properties changed.
Solution:
invalidateOnChildChange: trueto the options slot decorator in ToolbarSelect to trigger re-rendering when child ToolbarSelectOption properties changeFixes: #12619