-
Notifications
You must be signed in to change notification settings - Fork 11
Update: Merge current main(prod) to refactor/styles-migration #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for webdevpathstage ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Satoshi-Sh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this merge, we might want to set the rule for the refactor/styles-migration like needing 2 approvals to merge?
one might be ok, since we'll have to review again when merging back to main |
cherylli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
I feel it's better to have two reviews on small portions, as a merge to main will be huge. |
|
Maybe we could do: |
Have you updated the CHANGELOG.md file? If not, please do it.
Other devs already did.
What is this change?
Update: Merge the current main(prod) to refactor/styles-migration.
Were there any complications while making this change?
None.
When should this be merged?
Can be merge to refactor/styles-migration as soon as we are able.