Add struct.new_desc and struct.new_default_desc #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggsted in #81 (comment), add new instructions for allocations that take descriptor operands. Validate that all allocations of types with descriptors (and only those allocations) use the new instructions. Update the overview, interpreter, and tests. As a drive-by in the overview, fix outdated references to RTTs.
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Nov 20, 2025
and struct.new_default_desc to replace struct.new and struct.new_default, respectively, for allocating described types. Validate that struct.new_desc and struct.new_default_desc cannot be used to allocate non-described types. In the future we will also validate that they must be used to allocate described types, but to allow for a graceful update period, that validation is commented out for now. The corresponding proposal PR is WebAssembly/custom-descriptors#85. Bug: 403372470 Change-Id: I399164ac38bdf7cbb930e14ee90bca1bb8c5873e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7171646 Commit-Queue: Thomas Lively <tlively@google.com> Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#103858}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggsted in
#81 (comment),
add new instructions for allocations that take descriptor operands.
Validate that all allocations of types with descriptors (and only those
allocations) use the new instructions. Update the overview, interpreter,
and tests.
As a drive-by in the overview, fix outdated references to RTTs.