Skip to content

[js-api] Add test case for externref global #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[js-api] Add test case for externref global #1983

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c857e83
[js-api] Add test case for externref global
Liedtke Sep 23, 2025
d82c98b
Only test the constructor
Liedtke Oct 20, 2025
4cb2ba5
Add test case for value assignment and valueOf()
Liedtke Oct 20, 2025
76ac446
remove Object.is again
Liedtke Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion test/js-api/global/constructor.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,5 +167,31 @@ test(() => {

test(() => {
const argument = { "value": "v128" };
assert_throws_js(TypeError, () =>new WebAssembly.Global(argument));
assert_throws_js(TypeError, () => new WebAssembly.Global(argument));
}, "Construct v128 global");

test(() => {
let global = new WebAssembly.Global({value: "externref"}, "initial value");
assert_Global(global, "initial value");
for (let value of [
undefined,
null,
true,
1,
-0,
1.5,
-2n,
Symbol("test"),
"string",
{"an": "object"},
() => null
]) {
global.value = value;
Copy link
Collaborator

@Ms2ger Ms2ger Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this going to throw an assertion in step 5 because you didn't pass mutable: true in the constructor?

assert_Global(global, value);
}
}, "externref global");
Comment on lines 185 to 190
Copy link
Collaborator

@Ms2ger Ms2ger Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case isn't testing the constructor, which is what this file is for. I believe there's a file for the value getter/setter nearby

Copy link
Contributor Author

@Liedtke Liedtke Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. After checking how I missed that, I realized that I missed one "include" in my invocation for this file and that script was reponsible for actually executing the test cases. (It isn't very obvious to me how to run these scripts in e.g. d8.)

I addressed this issue now by splitting it up into testing the constructor and a separate test case for get-set.


test(() => {
let global = new WebAssembly.Global({value: "externref"});
assert_Global(global, undefined);
}, "externref global with default value");