wasip2: Reimplement directory streams #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
changed the title
pchickey
approved these changes
Nov 10, 2025
Collaborator
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
It would be good to have a test that exercises rewinddir and seekdir - https://github.com/WebAssembly/wasi-libc/blob/main/test/src/misc/opendir.c and https://github.com/WebAssembly/wasi-libc/blob/main/test/src/misc/scandir.c are the existing coverage in this area.
The main goal of this commit is to simplify what's located in the descriptor table of libc. Primarily directory streams are no longer located in the table and are instead stored directly in the `DIR*` structure. Additionally the wasip1-style `cookie` is removed in favor of a wasip2-specific offset counter. Along the way `__wasilibc_nocwd_scandirat` was rewritten for both wasip1 and wasip2 to be built on `openat` + `fdopendir`. This removes WASI-version-specific code and makes this look more similar to `scandir` elsewhere in libc.
alexcrichton
force-pushed
the
less-directories-in-descriptor-table
branch
from
a7ea6d6 to
d039b01
Compare
pchickey
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this commit is to simplify what's located in the descriptor table of libc. Primarily directory streams are no longer located in the table and are instead stored directly in the
DIR*structure. Additionally the wasip1-stylecookieis removed in favor of a wasip2-specific offset counter. Along the way__wasilibc_nocwd_scandiratwas rewritten for both wasip1 and wasip2 to be built onopenat+fdopendir. This removes WASI-version-specific code and makes this look more similar toscandirelsewhere in libc.