-
Notifications
You must be signed in to change notification settings - Fork 0
Add encrypted admin w/"no count" pagination #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: INTPYTHON-527
Are you sure you want to change the base?
Conversation
6559022 to
8a1d630
Compare
Existing approaches to "no count" pagination do not seem to include support for pagination in the Django admin, so: - Subclass Django's core Paginator - override count - Subclass Django's contrib admin view ChangeList.get_results - Use len instead of count - Ruff fixes for try/except - Subclass Django's contrib ModelAdmin - override get_paginator - override get_changelist
8a1d630 to
159f260
Compare
|
As I said before, Perhaps it works for testing a toy project with a small collection, but I'm unsure we should ship this approach to enterprise customers. We can check with the team before investing more time, like adding tests. |
58dd814 to
301e1b4
Compare
We should not ship a toy to the enterprise but we should figure out how to implement this feature so folks can use the Django admin. |
Existing approaches to "no count" pagination do not seem to include support for pagination in the Django admin, so:
Subclass Django's core Paginator
Subclass Django's contrib admin view ChangeList.get_results
Subclass Django's contrib ModelAdmin