Update fillCircleHelper (and related methods) to be consistent with drawCircleHelper #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method fillCircleHelper is inconsistent with the drawCircleHelper method. The brief for fillCircleHelper suggests it can render quarter circle segments while only capable of rendering half circles, while the brief for drawCircleHelper inaccurately states it only supports two mask bits while actually supporting four, one for each quadrant.
This PR addresses that by modifying fillCircleHelper to draw each corner independently. This makes the fillCircleHelper implementation consistent with drawCircleHelper, at the cost of fillCircleHelper being slightly less efficient (four calls to writeFastVLine instead of two). The two dependent methods, fillCircle and fillRoundRect, have also been updated to correctly use this new implementation. The briefs for fillCircleHelper and drawCircleHelper have been updated to more accurately reflect their functionality.