Skip to content

Conversation

@BillMerryman
Copy link
Contributor

The method fillCircleHelper is inconsistent with the drawCircleHelper method. The brief for fillCircleHelper suggests it can render quarter circle segments while only capable of rendering half circles, while the brief for drawCircleHelper inaccurately states it only supports two mask bits while actually supporting four, one for each quadrant.

This PR addresses that by modifying fillCircleHelper to draw each corner independently. This makes the fillCircleHelper implementation consistent with drawCircleHelper, at the cost of fillCircleHelper being slightly less efficient (four calls to writeFastVLine instead of two). The two dependent methods, fillCircle and fillRoundRect, have also been updated to correctly use this new implementation. The briefs for fillCircleHelper and drawCircleHelper have been updated to more accurately reflect their functionality.

@BillMerryman BillMerryman closed this by deleting the head repository Nov 1, 2025
@BillMerryman
Copy link
Contributor Author

I closed this pull request to resubmit with an alternative approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant