fix(mastra): Set new memory property on agent.stream #717
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not setting the new `memory` property when callnig `mastra.stream`, which means that in newer versions of mastra that the `threadId` and `resourceId` properties aren't being persisted through. I've now set this, but kept the old `threadId` and `resourceId` properties around with a deprecation comment instead.
Craga89
requested review from
NathanTarbert,
ataibarkai,
maxkorp,
mme,
ranst91 and
tylerslaton
as code owners
Craga89
commented
Nov 19, 2025
Craga89
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not setting the new
memoryproperty when callnigmastra.stream, which means that in newer versions of mastra that thethreadIdandresourceIdproperties aren't being persisted through.I've now set this, but kept the old
threadIdandresourceIdproperties around with a deprecation comment instead.