Skip to content

feat: add support async context managers in subscribers #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add support async context managers in subscribers #2576

wants to merge 3 commits into from

Conversation

@IvanKirpichnikov
Copy link
Contributor

@IvanKirpichnikov IvanKirpichnikov commented Oct 13, 2025 •
edited
Loading

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (just lint shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running just test-coverage
  • I have ensured that static analysis tests are passing by running just static-analysis
  • I have included code examples to illustrate the modifications

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 13, 2025
@IvanKirpichnikov
Copy link
Contributor Author

IvanKirpichnikov commented Oct 13, 2025

How look my edits in docs. (Before, after screens)

Dynamic subscriber

For aiokafka

Before

Before

After

After

For confluent

Before

Before

After

After

For rabbitmq

Before

Before

After

After

For nats

Before

Before

After

After

For redis

Before

Before

After

After

Lancetnik
Lancetnik requested changes Oct 14, 2025
View reviewed changes
Copy link
Member

@Lancetnik Lancetnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a test case to tests/brokers/base/consume.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lancetnik Lancetnik Lancetnik requested changes

@kumaranvpl kumaranvpl Awaiting requested review from kumaranvpl kumaranvpl is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IvanKirpichnikov @Lancetnik